Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Skip double formatting #31

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

fkleedorfer
Copy link
Contributor

@fkleedorfer fkleedorfer commented Sep 16, 2024

Provides a new style property, skipDoubleFormatting (default true) that causes all double values to be formatted as they are in the input.

(also adds a main method to the TurtleFormatter for easy testing)

closes #30

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 45.83333% with 13 lines in your changes missing coverage. Please review.

Project coverage is 88.66%. Comparing base (8104469) to head (f56f8b4).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
...a/de/atextor/turtle/formatter/TurtleFormatter.java 45.83% 10 Missing and 3 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #31      +/-   ##
============================================
+ Coverage     88.26%   88.66%   +0.40%     
- Complexity      198      223      +25     
============================================
  Files             3        6       +3     
  Lines           443      609     +166     
  Branches         84      100      +16     
============================================
+ Hits            391      540     +149     
- Misses           32       49      +17     
  Partials         20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- remove `main()` method
- simplify if cascad
Copy link
Owner

@atextor atextor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@atextor atextor merged commit 7b3eeb9 into atextor:main Sep 20, 2024
3 checks passed
@fkleedorfer
Copy link
Contributor Author

Again, a release of this will be greatly appreaciated. (sorry to be pushy about this)

@atextor
Copy link
Owner

atextor commented Sep 21, 2024

Again, a release of this will be greatly appreaciated. (sorry to be pushy about this)

Yes, I'm aware :)
It's released now as 1.2.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formatting double values is not always appropriate
3 participants