Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update isomorphic-dompurify and remove @types/highlight.js #1034

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

batyshkaLenin
Copy link
Contributor

Changes proposed in this pull request:

  • Remove @types/highlight.js, because highlight.js have own type definitions
  • Update isomorphic-dompurify and @types/dompurify

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@derberg
Copy link
Member

derberg commented Aug 20, 2024

@batyshkaLenin thanks, can you share why these updates : Update isomorphic-dompurify and @types/dompurify are needed?

@batyshkaLenin
Copy link
Contributor Author

@derberg @types/highlight.js I removed because this library has its own type declarations. isomorphic-dompurify I updated because, every time I installed dependencies in my project, there was a warning that one of its dependencies had a CVE (I don't remember which one, I made this PR over two weeks ago). @types/dompurify I updated to not have conflicting type versions in package-json, because isomorphic-dompurify has a different type version. In a broader view, there was no big need to upgrade, I wanted to get rid of the warning when installing dependencies in my project.

Copy link

sonarcloud bot commented Sep 2, 2024

@derberg derberg changed the title chore(deps): update isomorphic-dompurify and remove @types/highlight.js fix: update isomorphic-dompurify and remove @types/highlight.js Sep 2, 2024
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, since we update dev dependency, we should release patch, this is why I changed the prefix to fix:

@derberg
Copy link
Member

derberg commented Sep 2, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit d033861 into asyncapi:master Sep 2, 2024
13 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants