Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flake8-simplify] - Fix syntax error in autofix (SIM114) #9704

Merged
merged 1 commit into from
Jan 30, 2024
Merged

[flake8-simplify] - Fix syntax error in autofix (SIM114) #9704

merged 1 commit into from
Jan 30, 2024

Conversation

diceroll123
Copy link
Contributor

@diceroll123 diceroll123 commented Jan 30, 2024 •
edited by AlexWaygood
Loading

Summary

A fix for #8402 (comment)

Improves the code, as well. :)

Test Plan

cargo test

@AlexWaygood AlexWaygood added bug Something isn't working fixes Related to suggested fixes for violations labels Jan 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

charliermarsh
charliermarsh approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charliermarsh charliermarsh merged commit 2145632 into astral-sh:main Jan 30, 2024
17 checks passed
@miccal miccal mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
bug Something isn't working fixes Related to suggested fixes for violations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diceroll123 @charliermarsh @AlexWaygood