Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that ecosystem check job fails if the tooling encounters an unexpected error #8365

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Ensure that ecosystem check job fails if the tooling encounters an unexpected error #8365

merged 3 commits into from
Oct 31, 2023

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Oct 30, 2023 •
edited
Loading

Previously, | tee would hide bad exit codes from ruff-ecosystem ...

See poc failure at https://github.com/astral-sh/ruff/actions/runs/6698487019/job/18200852648?pr=8365

@zanieb zanieb added the internal An internal refactor or improvement label Oct 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2023 •
edited
Loading

PR Check Results

Ecosystem

✅ ecosystem check detected no linter changes.

✅ ecosystem check detected no format changes.

@zanieb zanieb merged commit 982ae6f into main Oct 31, 2023
17 checks passed
@zanieb zanieb deleted the zanie/ecosystem-fail branch October 31, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
internal An internal refactor or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zanieb @charliermarsh