Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic with 8 in octal escape #8356

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Fix panic with 8 in octal escape #8356

merged 2 commits into from
Oct 30, 2023

Conversation

konstin
Copy link
Member

@konstin konstin commented Oct 30, 2023

Summary The digits for an octal escape are 0 to 7, not 0 to 8, fixing the panic in #8355

Test plan Regression test parser fixture

**Summary** The digits for an octal escape are 0 to 7, not 0 to 8, fixing the panic in #8355

**Test plan** Regression test parser fixture
@konstin konstin added bug Something isn't working parser Related to the parser labels Oct 30, 2023
@konstin konstin merged commit daea870 into main Oct 30, 2023
16 checks passed
@konstin konstin deleted the octal-escape branch October 30, 2023 13:42
@github-actions
Copy link
Contributor

PR Check Results

Ecosystem

✅ ecosystem check detected no linter changes.

✅ ecosystem check detected no format changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parser Related to the parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants