Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(parser): use memchr for lexing comments #8193

Merged
merged 5 commits into from
Oct 27, 2023
Merged

perf(parser): use memchr for lexing comments #8193

merged 5 commits into from
Oct 27, 2023

Commits on Oct 25, 2023

  1. perf(parser): use memchr for lexing comments 

    We now use memchr on its SIMD-supported targets to improve the
performance of lexing comments.
    @sno2
    sno2 committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    410f157 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/sno2/ruff

    @sno2
    sno2 committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    a0f2442 View commit details
    Browse the repository at this point in the history

  3. always use memchr

    @sno2
    sno2 committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    5981046 View commit details
    Browse the repository at this point in the history

  4. perf(parser): try using compact_str for comments 

    This might improve performance here because we do not compare comments
to values that often. Therefore, the memory locality might improve
performance in certain cases as well.
    @sno2
    sno2 committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    0578954 View commit details
    Browse the repository at this point in the history

  5. Revert "perf(parser): try using compact_str for comments" 

    Using compact_str does not seem to be faster for us :(
    @sno2
    sno2 committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    0d3717f View commit details
    Browse the repository at this point in the history