Parenthesize expressions prior to LibCST parsing #6742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/parens
branch
from
770ef07
to
4f95c35
Compare
charliermarsh
force-pushed
the
charlie/parens
branch
from
4f95c35
to
8af08eb
Compare
charliermarsh
commented
Aug 21, 2023
charliermarsh
force-pushed
the
charlie/parens
branch
from
8af08eb
to
38f5a9f
Compare
PR Check ResultsEcosystemℹ️ ecosystem check detected changes. (+31, -31, 0 error(s)) airflow (+31, -31)
- helm_tests/airflow_aux/test_basic_helm_chart.py:572:13: SIM300 Yoda conditions are discouraged + helm_tests/airflow_aux/test_basic_helm_chart.py:572:13: SIM300 [*] Yoda conditions are discouraged - helm_tests/airflow_aux/test_basic_helm_chart.py:585:13: SIM300 Yoda conditions are discouraged + helm_tests/airflow_aux/test_basic_helm_chart.py:585:13: SIM300 [*] Yoda conditions are discouraged - helm_tests/airflow_aux/test_cleanup_pods.py:267:13: SIM300 Yoda conditions are discouraged + helm_tests/airflow_aux/test_cleanup_pods.py:267:13: SIM300 [*] Yoda conditions are discouraged - helm_tests/airflow_aux/test_cleanup_pods.py:274:13: SIM300 Yoda conditions are discouraged + helm_tests/airflow_aux/test_cleanup_pods.py:274:13: SIM300 [*] Yoda conditions are discouraged - helm_tests/airflow_aux/test_configmap.py:85:13: SIM300 Yoda conditions are discouraged + helm_tests/airflow_aux/test_configmap.py:85:13: SIM300 [*] Yoda conditions are discouraged - helm_tests/other/test_pgbouncer.py:582:13: SIM300 Yoda conditions are discouraged + helm_tests/other/test_pgbouncer.py:582:13: SIM300 [*] Yoda conditions are discouraged - helm_tests/security/test_elasticsearch_secret.py:99:13: SIM300 Yoda conditions are discouraged + helm_tests/security/test_elasticsearch_secret.py:99:13: SIM300 [*] Yoda conditions are discouraged - helm_tests/security/test_metadata_connection_secret.py:125:13: SIM300 Yoda conditions are discouraged + helm_tests/security/test_metadata_connection_secret.py:125:13: SIM300 [*] Yoda conditions are discouraged - helm_tests/security/test_metadata_connection_secret.py:57:13: SIM300 Yoda conditions are discouraged + helm_tests/security/test_metadata_connection_secret.py:57:13: SIM300 [*] Yoda conditions are discouraged - helm_tests/security/test_metadata_connection_secret.py:67:13: SIM300 Yoda conditions are discouraged + helm_tests/security/test_metadata_connection_secret.py:67:13: SIM300 [*] Yoda conditions are discouraged - helm_tests/security/test_metadata_connection_secret.py:80:13: SIM300 Yoda conditions are discouraged + helm_tests/security/test_metadata_connection_secret.py:80:13: SIM300 [*] Yoda conditions are discouraged - helm_tests/security/test_result_backend_connection_secret.py:143:13: SIM300 Yoda conditions are discouraged + helm_tests/security/test_result_backend_connection_secret.py:143:13: SIM300 [*] Yoda conditions are discouraged - helm_tests/security/test_result_backend_connection_secret.py:207:13: SIM300 Yoda conditions are discouraged + helm_tests/security/test_result_backend_connection_secret.py:207:13: SIM300 [*] Yoda conditions are discouraged - helm_tests/webserver/test_webserver.py:936:13: SIM300 Yoda conditions are discouraged + helm_tests/webserver/test_webserver.py:936:13: SIM300 [*] Yoda conditions are discouraged - tests/providers/google/cloud/hooks/test_cloud_storage_transfer_service.py:785:13: SIM300 Yoda conditions are discouraged + tests/providers/google/cloud/hooks/test_cloud_storage_transfer_service.py:785:13: SIM300 [*] Yoda conditions are discouraged - tests/providers/google/cloud/hooks/test_cloud_storage_transfer_service.py:806:13: SIM300 Yoda conditions are discouraged + tests/providers/google/cloud/hooks/test_cloud_storage_transfer_service.py:806:13: SIM300 [*] Yoda conditions are discouraged - tests/providers/google/cloud/hooks/test_cloud_storage_transfer_service.py:834:13: SIM300 Yoda conditions are discouraged + tests/providers/google/cloud/hooks/test_cloud_storage_transfer_service.py:834:13: SIM300 [*] Yoda conditions are discouraged - tests/providers/google/cloud/hooks/test_cloud_storage_transfer_service.py:879:13: SIM300 Yoda conditions are discouraged + tests/providers/google/cloud/hooks/test_cloud_storage_transfer_service.py:879:13: SIM300 [*] Yoda conditions are discouraged - tests/providers/google/cloud/hooks/test_cloud_storage_transfer_service.py:897:13: SIM300 Yoda conditions are discouraged + tests/providers/google/cloud/hooks/test_cloud_storage_transfer_service.py:897:13: SIM300 [*] Yoda conditions are discouraged - tests/providers/google/cloud/hooks/test_cloud_storage_transfer_service.py:924:13: SIM300 Yoda conditions are discouraged + tests/providers/google/cloud/hooks/test_cloud_storage_transfer_service.py:924:13: SIM300 [*] Yoda conditions are discouraged - tests/providers/google/cloud/hooks/test_life_sciences.py:300:13: SIM300 Yoda conditions are discouraged + tests/providers/google/cloud/hooks/test_life_sciences.py:300:13: SIM300 [*] Yoda conditions are discouraged - tests/providers/google/cloud/operators/test_mlengine.py:250:13: SIM300 Yoda conditions are discouraged + tests/providers/google/cloud/operators/test_mlengine.py:250:13: SIM300 [*] Yoda conditions are discouraged - tests/providers/google/cloud/operators/test_mlengine.py:259:13: SIM300 Yoda conditions are discouraged + tests/providers/google/cloud/operators/test_mlengine.py:259:13: SIM300 [*] Yoda conditions are discouraged - tests/providers/google/firebase/hooks/test_firestore.py:243:13: SIM300 Yoda conditions are discouraged + tests/providers/google/firebase/hooks/test_firestore.py:243:13: SIM300 [*] Yoda conditions are discouraged - tests/www/test_utils.py:275:13: SIM300 Yoda conditions are discouraged + tests/www/test_utils.py:275:13: SIM300 [*] Yoda conditions are discouraged - tests/www/test_utils.py:289:13: SIM300 Yoda conditions are discouraged + tests/www/test_utils.py:289:13: SIM300 [*] Yoda conditions are discouraged - tests/www/test_utils.py:305:13: SIM300 Yoda conditions are discouraged + tests/www/test_utils.py:305:13: SIM300 [*] Yoda conditions are discouraged - tests/www/test_utils.py:333:13: SIM300 Yoda conditions are discouraged + tests/www/test_utils.py:333:13: SIM300 [*] Yoda conditions are discouraged - tests/www/test_utils.py:354:13: SIM300 Yoda conditions are discouraged + tests/www/test_utils.py:354:13: SIM300 [*] Yoda conditions are discouraged - tests/www/test_utils.py:372:13: SIM300 Yoda conditions are discouraged + tests/www/test_utils.py:372:13: SIM300 [*] Yoda conditions are discouraged - tests/www/test_utils.py:401:13: SIM300 Yoda conditions are discouraged + tests/www/test_utils.py:401:13: SIM300 [*] Yoda conditions are discouraged
BenchmarkLinuxWindows |
charliermarsh
force-pushed
the
charlie/parens
branch
from
38f5a9f
to
186650c
Compare
charliermarsh
added a commit
that referenced
this pull request
Aug 22, 2023
## Summary I noticed this in the ecosystem CI check from #6742. If we include source code directly in a diagnostic, we need to be careful to avoid rendering multi-line diagnostics or even excessively long diagnostics. ## Test Plan `cargo test`
charliermarsh
force-pushed
the
charlie/parens
branch
from
186650c
to
2031850
Compare
MichaReiser
approved these changes
Aug 22, 2023
Comment on lines
+216
to
+219
| /// expression is not a valid standalone expression (e.g., it was parenthesized in the original | ||
| /// source). This method instead wraps the expression in "fake" parentheses, runs the |
There was a problem hiding this comment.
Suggested change
| /// expression is not a valid standalone expression (e.g., it was parenthesized in the original | |
| /// source). This method instead wraps the expression in "fake" parentheses, runs the | |
| /// expression is not a valid standalone expression (e.g., it or any enclosing expression are parenthesized in the original | |
| /// source). This method instead wraps the expression in "fake" parentheses, runs the |
| let source_code = format!("({source_code})"); | ||
|
|
||
| // Run the function on the expression. | ||
| let mut transformed = func(source_code)?; |
There was a problem hiding this comment.
I would expect this method to orchestrate the whole transformation: Meaning it
- should call
match_expressionon the source and pass the expression tofunc. Ideally, it would pass the unparenthesized expression, but I think this isn't possible because libCST stores the parenthesized as a field rather than having a separateParenthesizedExpressionnode. funcmutates the expression and returns a new expression.- it calls
codegen, returning the unparenthesized expression
This may have the added benefit that it can remove the parentheses by mutating the CST rather than manipulating the returned string.
There was a problem hiding this comment.
I structured it this way initially but I lost like an hour or two fighting lifetimes. Let me revisit...
There was a problem hiding this comment.
This may have the added benefit that it can remove the parentheses by mutating the CST rather than manipulating the returned string.
Unfortunately LibCST doesn't let you do this, AFAICT :(
There was a problem hiding this comment.
I can't for the life of me figure out how to make the lifetimes work. The issue is in format_literals.rs where we already have to use an Arena to solve weird lifetime problems. Now changing the signature of transform_expression gives me:
error[E0597]: `arena` does not live long enough
--> crates/ruff/src/rules/pyupgrade/rules/format_literals.rs:220:44
|
210 | let output = transform_ex(source_code, stylist, |mut expression| {
| -------------- has type `libcst_native::Expression<'1>`
...
219 | let arena = typed_arena::Arena::new();
| ----- binding `arena` declared here
220 | remove_specifiers(&mut item.value, &arena);
| -----------------------------------^^^^^^-
| | |
| | borrowed value does not live long enough
| argument requires that `arena` is borrowed for `'1`
...
223 | })?;
| - `arena` dropped here while still borrowedI've tried moving the arena out of the closure, messing with lifetimes, etc.
There was a problem hiding this comment.
I was able to change this everywhere except format_literals.rs.
charliermarsh
force-pushed
the
charlie/parens
branch
from
2031850
to
56b8382
Compare
renovate bot
referenced
this pull request
in ixm-one/pytest-cmake-presets
Aug 25, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://beta.ruff.rs/docs) ([source](https://github.com/astral-sh/ruff), [changelog](https://github.com/astral-sh/ruff/releases)) | `^0.0.285` -> `^0.0.286` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>astral-sh/ruff (ruff)</summary> ### [`v0.0.286`](https://github.com/astral-sh/ruff/releases/tag/v0.0.286) [Compare Source](https://github.com/astral-sh/ruff/compare/v0.0.285...v0.0.286) <!-- Release notes generated using configuration in .github/release.yml at v0.0.286 --> #### What's Changed ##### New Rules - \[`flake8-bugbear`] Update `function-call-in-argument-default` (`B008`) to ignore arguments with immutable annotations by [@​zanieb](https://github.com/zanieb) in [https://github.com/astral-sh/ruff/pull/6784](https://github.com/astral-sh/ruff/pull/6784) - \[`flake8-bugbear`] Update `mutable-argument-default` (`B006`) to use `extend-immutable-calls` when determining if annotations are immutable by [@​zanieb](https://github.com/zanieb) in [https://github.com/astral-sh/ruff/pull/6781](https://github.com/astral-sh/ruff/pull/6781) - \[`flake8-pie`] Implement `unnecessary-range-start` (`PIE808`) by [@​harupy](https://github.com/harupy) in [https://github.com/astral-sh/ruff/pull/6690](https://github.com/astral-sh/ruff/pull/6690) - \[`flake8-pytest-style`] Add autofix for `PT014` by [@​harupy](https://github.com/harupy) in [https://github.com/astral-sh/ruff/pull/6698](https://github.com/astral-sh/ruff/pull/6698) - \[`pylint`] Implement `no-self-use` (`R6301`) by [@​LaBatata101](https://github.com/LaBatata101) in [https://github.com/astral-sh/ruff/pull/6574](https://github.com/astral-sh/ruff/pull/6574) - \[`pylint`] Extend `repeated-equality-comparison-target` to check for mixed orderings and Yoda conditions. by [@​tjkuson](https://github.com/tjkuson) in [https://github.com/astral-sh/ruff/pull/6691](https://github.com/astral-sh/ruff/pull/6691) ##### Settings - Make isort's `detect-same-package` behavior configurable by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6833](https://github.com/astral-sh/ruff/pull/6833) ##### Bug Fixes - Apply RUF017 when start is passed via position by [@​hauntsaninja](https://github.com/hauntsaninja) in [https://github.com/astral-sh/ruff/pull/6664](https://github.com/astral-sh/ruff/pull/6664) - Use `typing_extensions.TypeAlias` for PYI026 fixes on pre-3.10 by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6696](https://github.com/astral-sh/ruff/pull/6696) - Ignore multi-comparisons in `repeated-equality-comparison-target` by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6705](https://github.com/astral-sh/ruff/pull/6705) - Accept empty inner calls in C414 by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6725](https://github.com/astral-sh/ruff/pull/6725) - Allow next in FBT exclusions by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6729](https://github.com/astral-sh/ruff/pull/6729) - Allow `ctypes.WinError()` in flake8-raise by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6731](https://github.com/astral-sh/ruff/pull/6731) - Ignore star imports when importing symbols in fixes by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6743](https://github.com/astral-sh/ruff/pull/6743) - Support C419 autofixes for set comprehensions by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6744](https://github.com/astral-sh/ruff/pull/6744) - Avoid attempting to fix unconventional submodule imports by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6745](https://github.com/astral-sh/ruff/pull/6745) - Don't trigger `eq-without-hash` when `__hash__` is explicitly set to `None` by [@​LaBatata101](https://github.com/LaBatata101) in [https://github.com/astral-sh/ruff/pull/6739](https://github.com/astral-sh/ruff/pull/6739) - Avoid E231 if comma is at end-of-line by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6747](https://github.com/astral-sh/ruff/pull/6747) - Truncate some messages in diagnostics by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6748](https://github.com/astral-sh/ruff/pull/6748) - Fix isolation groups for unused imports by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6774](https://github.com/astral-sh/ruff/pull/6774) - Avoid fixing D200 for docstrings that end in escapes by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6779](https://github.com/astral-sh/ruff/pull/6779) - Parenthesize expressions prior to LibCST parsing by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6742](https://github.com/astral-sh/ruff/pull/6742) - Fallback to end-of-file if ends in trailing continuation by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6789](https://github.com/astral-sh/ruff/pull/6789) - Confine repeated-equality-comparison-target to names and attributes by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6802](https://github.com/astral-sh/ruff/pull/6802) - Fix `native-literals` handling of int literal with attribute access by [@​zanieb](https://github.com/zanieb) in [https://github.com/astral-sh/ruff/pull/6792](https://github.com/astral-sh/ruff/pull/6792) - Fix `uncessary-coding-comment` fix when there's leading content by [@​zanieb](https://github.com/zanieb) in [https://github.com/astral-sh/ruff/pull/6775](https://github.com/astral-sh/ruff/pull/6775) - Avoid attempting to fix PT018 in multi-statement lines by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6829](https://github.com/astral-sh/ruff/pull/6829) - Update ERA100 to apply to commented dictionary items with trailing comments by [@​zanieb](https://github.com/zanieb) in [https://github.com/astral-sh/ruff/pull/6822](https://github.com/astral-sh/ruff/pull/6822) - Avoid parsing other parts of a format specification if replacements are present by [@​zanieb](https://github.com/zanieb) in [https://github.com/astral-sh/ruff/pull/6858](https://github.com/astral-sh/ruff/pull/6858) - Avoid panic in unused arguments rule for parameter-free lambda by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6679](https://github.com/astral-sh/ruff/pull/6679) - Avoid `C417` for `lambda` with default and variadic parameters by [@​dhruvmanila](https://github.com/dhruvmanila) in [https://github.com/astral-sh/ruff/pull/6752](https://github.com/astral-sh/ruff/pull/6752) - Add `networkx` to conventional aliases by [@​zanieb](https://github.com/zanieb) in [https://github.com/astral-sh/ruff/pull/6778](https://github.com/astral-sh/ruff/pull/6778) - Skip serializing cell ID if it's None by [@​harupy](https://github.com/harupy) in [https://github.com/astral-sh/ruff/pull/6851](https://github.com/astral-sh/ruff/pull/6851) - fix is_raw_string for multiple prefixes by [@​davidszotten](https://github.com/davidszotten) in [https://github.com/astral-sh/ruff/pull/6865](https://github.com/astral-sh/ruff/pull/6865) - Add jupyter notebook cell ids in 4.5+ if missing by [@​konstin](https://github.com/konstin) in [https://github.com/astral-sh/ruff/pull/6853](https://github.com/astral-sh/ruff/pull/6853) **Full Changelog**: astral-sh/ruff@v0.0.285...v0.0.286 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ixm-one/pytest-cmake-presets). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzYuNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
jankatins
referenced
this pull request
in jankatins/pr-workflow-example
Aug 26, 2023
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://beta.ruff.rs/docs) ([source](https://github.com/astral-sh/ruff), [changelog](https://github.com/astral-sh/ruff/releases)) | `0.0.285` -> `0.0.286` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>astral-sh/ruff (ruff)</summary> ### [`v0.0.286`](https://github.com/astral-sh/ruff/releases/tag/v0.0.286) [Compare Source](https://github.com/astral-sh/ruff/compare/v0.0.285...v0.0.286) <!-- Release notes generated using configuration in .github/release.yml at v0.0.286 --> #### What's Changed ##### New Rules - \[`flake8-bugbear`] Update `function-call-in-argument-default` (`B008`) to ignore arguments with immutable annotations by [@​zanieb](https://github.com/zanieb) in [https://github.com/astral-sh/ruff/pull/6784](https://github.com/astral-sh/ruff/pull/6784) - \[`flake8-bugbear`] Update `mutable-argument-default` (`B006`) to use `extend-immutable-calls` when determining if annotations are immutable by [@​zanieb](https://github.com/zanieb) in [https://github.com/astral-sh/ruff/pull/6781](https://github.com/astral-sh/ruff/pull/6781) - \[`flake8-pie`] Implement `unnecessary-range-start` (`PIE808`) by [@​harupy](https://github.com/harupy) in [https://github.com/astral-sh/ruff/pull/6690](https://github.com/astral-sh/ruff/pull/6690) - \[`flake8-pytest-style`] Add autofix for `PT014` by [@​harupy](https://github.com/harupy) in [https://github.com/astral-sh/ruff/pull/6698](https://github.com/astral-sh/ruff/pull/6698) - \[`pylint`] Implement `no-self-use` (`R6301`) by [@​LaBatata101](https://github.com/LaBatata101) in [https://github.com/astral-sh/ruff/pull/6574](https://github.com/astral-sh/ruff/pull/6574) - \[`pylint`] Extend `repeated-equality-comparison-target` to check for mixed orderings and Yoda conditions. by [@​tjkuson](https://github.com/tjkuson) in [https://github.com/astral-sh/ruff/pull/6691](https://github.com/astral-sh/ruff/pull/6691) ##### Settings - Make isort's `detect-same-package` behavior configurable by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6833](https://github.com/astral-sh/ruff/pull/6833) ##### Bug Fixes - Apply RUF017 when start is passed via position by [@​hauntsaninja](https://github.com/hauntsaninja) in [https://github.com/astral-sh/ruff/pull/6664](https://github.com/astral-sh/ruff/pull/6664) - Use `typing_extensions.TypeAlias` for PYI026 fixes on pre-3.10 by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6696](https://github.com/astral-sh/ruff/pull/6696) - Ignore multi-comparisons in `repeated-equality-comparison-target` by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6705](https://github.com/astral-sh/ruff/pull/6705) - Accept empty inner calls in C414 by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6725](https://github.com/astral-sh/ruff/pull/6725) - Allow next in FBT exclusions by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6729](https://github.com/astral-sh/ruff/pull/6729) - Allow `ctypes.WinError()` in flake8-raise by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6731](https://github.com/astral-sh/ruff/pull/6731) - Ignore star imports when importing symbols in fixes by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6743](https://github.com/astral-sh/ruff/pull/6743) - Support C419 autofixes for set comprehensions by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6744](https://github.com/astral-sh/ruff/pull/6744) - Avoid attempting to fix unconventional submodule imports by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6745](https://github.com/astral-sh/ruff/pull/6745) - Don't trigger `eq-without-hash` when `__hash__` is explicitly set to `None` by [@​LaBatata101](https://github.com/LaBatata101) in [https://github.com/astral-sh/ruff/pull/6739](https://github.com/astral-sh/ruff/pull/6739) - Avoid E231 if comma is at end-of-line by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6747](https://github.com/astral-sh/ruff/pull/6747) - Truncate some messages in diagnostics by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6748](https://github.com/astral-sh/ruff/pull/6748) - Fix isolation groups for unused imports by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6774](https://github.com/astral-sh/ruff/pull/6774) - Avoid fixing D200 for docstrings that end in escapes by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6779](https://github.com/astral-sh/ruff/pull/6779) - Parenthesize expressions prior to LibCST parsing by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6742](https://github.com/astral-sh/ruff/pull/6742) - Fallback to end-of-file if ends in trailing continuation by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6789](https://github.com/astral-sh/ruff/pull/6789) - Confine repeated-equality-comparison-target to names and attributes by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6802](https://github.com/astral-sh/ruff/pull/6802) - Fix `native-literals` handling of int literal with attribute access by [@​zanieb](https://github.com/zanieb) in [https://github.com/astral-sh/ruff/pull/6792](https://github.com/astral-sh/ruff/pull/6792) - Fix `uncessary-coding-comment` fix when there's leading content by [@​zanieb](https://github.com/zanieb) in [https://github.com/astral-sh/ruff/pull/6775](https://github.com/astral-sh/ruff/pull/6775) - Avoid attempting to fix PT018 in multi-statement lines by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6829](https://github.com/astral-sh/ruff/pull/6829) - Update ERA100 to apply to commented dictionary items with trailing comments by [@​zanieb](https://github.com/zanieb) in [https://github.com/astral-sh/ruff/pull/6822](https://github.com/astral-sh/ruff/pull/6822) - Avoid parsing other parts of a format specification if replacements are present by [@​zanieb](https://github.com/zanieb) in [https://github.com/astral-sh/ruff/pull/6858](https://github.com/astral-sh/ruff/pull/6858) - Avoid panic in unused arguments rule for parameter-free lambda by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6679](https://github.com/astral-sh/ruff/pull/6679) - Avoid `C417` for `lambda` with default and variadic parameters by [@​dhruvmanila](https://github.com/dhruvmanila) in [https://github.com/astral-sh/ruff/pull/6752](https://github.com/astral-sh/ruff/pull/6752) - Add `networkx` to conventional aliases by [@​zanieb](https://github.com/zanieb) in [https://github.com/astral-sh/ruff/pull/6778](https://github.com/astral-sh/ruff/pull/6778) - Skip serializing cell ID if it's None by [@​harupy](https://github.com/harupy) in [https://github.com/astral-sh/ruff/pull/6851](https://github.com/astral-sh/ruff/pull/6851) - fix is_raw_string for multiple prefixes by [@​davidszotten](https://github.com/davidszotten) in [https://github.com/astral-sh/ruff/pull/6865](https://github.com/astral-sh/ruff/pull/6865) - Add jupyter notebook cell ids in 4.5+ if missing by [@​konstin](https://github.com/konstin) in [https://github.com/astral-sh/ruff/pull/6853](https://github.com/astral-sh/ruff/pull/6853) **Full Changelog**: astral-sh/ruff@v0.0.285...v0.0.286 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/jankatins/pr-workflow-example). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40MC4zIiwidXBkYXRlZEluVmVyIjoiMzYuNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
renovate bot
referenced
this pull request
in allenporter/flux-local
Aug 26, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://beta.ruff.rs/docs) ([source](https://github.com/astral-sh/ruff), [changelog](https://github.com/astral-sh/ruff/releases)) | `==0.0.285` -> `==0.0.286` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>astral-sh/ruff (ruff)</summary> ### [`v0.0.286`](https://github.com/astral-sh/ruff/releases/tag/v0.0.286) [Compare Source](https://github.com/astral-sh/ruff/compare/v0.0.285...v0.0.286) <!-- Release notes generated using configuration in .github/release.yml at v0.0.286 --> #### What's Changed ##### New Rules - \[`flake8-bugbear`] Update `function-call-in-argument-default` (`B008`) to ignore arguments with immutable annotations by [@​zanieb](https://github.com/zanieb) in [https://github.com/astral-sh/ruff/pull/6784](https://github.com/astral-sh/ruff/pull/6784) - \[`flake8-bugbear`] Update `mutable-argument-default` (`B006`) to use `extend-immutable-calls` when determining if annotations are immutable by [@​zanieb](https://github.com/zanieb) in [https://github.com/astral-sh/ruff/pull/6781](https://github.com/astral-sh/ruff/pull/6781) - \[`flake8-pie`] Implement `unnecessary-range-start` (`PIE808`) by [@​harupy](https://github.com/harupy) in [https://github.com/astral-sh/ruff/pull/6690](https://github.com/astral-sh/ruff/pull/6690) - \[`flake8-pytest-style`] Add autofix for `PT014` by [@​harupy](https://github.com/harupy) in [https://github.com/astral-sh/ruff/pull/6698](https://github.com/astral-sh/ruff/pull/6698) - \[`pylint`] Implement `no-self-use` (`R6301`) by [@​LaBatata101](https://github.com/LaBatata101) in [https://github.com/astral-sh/ruff/pull/6574](https://github.com/astral-sh/ruff/pull/6574) - \[`pylint`] Extend `repeated-equality-comparison-target` to check for mixed orderings and Yoda conditions. by [@​tjkuson](https://github.com/tjkuson) in [https://github.com/astral-sh/ruff/pull/6691](https://github.com/astral-sh/ruff/pull/6691) ##### Settings - Make isort's `detect-same-package` behavior configurable by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6833](https://github.com/astral-sh/ruff/pull/6833) ##### Bug Fixes - Apply RUF017 when start is passed via position by [@​hauntsaninja](https://github.com/hauntsaninja) in [https://github.com/astral-sh/ruff/pull/6664](https://github.com/astral-sh/ruff/pull/6664) - Use `typing_extensions.TypeAlias` for PYI026 fixes on pre-3.10 by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6696](https://github.com/astral-sh/ruff/pull/6696) - Ignore multi-comparisons in `repeated-equality-comparison-target` by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6705](https://github.com/astral-sh/ruff/pull/6705) - Accept empty inner calls in C414 by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6725](https://github.com/astral-sh/ruff/pull/6725) - Allow next in FBT exclusions by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6729](https://github.com/astral-sh/ruff/pull/6729) - Allow `ctypes.WinError()` in flake8-raise by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6731](https://github.com/astral-sh/ruff/pull/6731) - Ignore star imports when importing symbols in fixes by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6743](https://github.com/astral-sh/ruff/pull/6743) - Support C419 autofixes for set comprehensions by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6744](https://github.com/astral-sh/ruff/pull/6744) - Avoid attempting to fix unconventional submodule imports by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6745](https://github.com/astral-sh/ruff/pull/6745) - Don't trigger `eq-without-hash` when `__hash__` is explicitly set to `None` by [@​LaBatata101](https://github.com/LaBatata101) in [https://github.com/astral-sh/ruff/pull/6739](https://github.com/astral-sh/ruff/pull/6739) - Avoid E231 if comma is at end-of-line by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6747](https://github.com/astral-sh/ruff/pull/6747) - Truncate some messages in diagnostics by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6748](https://github.com/astral-sh/ruff/pull/6748) - Fix isolation groups for unused imports by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6774](https://github.com/astral-sh/ruff/pull/6774) - Avoid fixing D200 for docstrings that end in escapes by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6779](https://github.com/astral-sh/ruff/pull/6779) - Parenthesize expressions prior to LibCST parsing by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6742](https://github.com/astral-sh/ruff/pull/6742) - Fallback to end-of-file if ends in trailing continuation by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6789](https://github.com/astral-sh/ruff/pull/6789) - Confine repeated-equality-comparison-target to names and attributes by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6802](https://github.com/astral-sh/ruff/pull/6802) - Fix `native-literals` handling of int literal with attribute access by [@​zanieb](https://github.com/zanieb) in [https://github.com/astral-sh/ruff/pull/6792](https://github.com/astral-sh/ruff/pull/6792) - Fix `uncessary-coding-comment` fix when there's leading content by [@​zanieb](https://github.com/zanieb) in [https://github.com/astral-sh/ruff/pull/6775](https://github.com/astral-sh/ruff/pull/6775) - Avoid attempting to fix PT018 in multi-statement lines by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6829](https://github.com/astral-sh/ruff/pull/6829) - Update ERA100 to apply to commented dictionary items with trailing comments by [@​zanieb](https://github.com/zanieb) in [https://github.com/astral-sh/ruff/pull/6822](https://github.com/astral-sh/ruff/pull/6822) - Avoid parsing other parts of a format specification if replacements are present by [@​zanieb](https://github.com/zanieb) in [https://github.com/astral-sh/ruff/pull/6858](https://github.com/astral-sh/ruff/pull/6858) - Avoid panic in unused arguments rule for parameter-free lambda by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6679](https://github.com/astral-sh/ruff/pull/6679) - Avoid `C417` for `lambda` with default and variadic parameters by [@​dhruvmanila](https://github.com/dhruvmanila) in [https://github.com/astral-sh/ruff/pull/6752](https://github.com/astral-sh/ruff/pull/6752) - Add `networkx` to conventional aliases by [@​zanieb](https://github.com/zanieb) in [https://github.com/astral-sh/ruff/pull/6778](https://github.com/astral-sh/ruff/pull/6778) - Skip serializing cell ID if it's None by [@​harupy](https://github.com/harupy) in [https://github.com/astral-sh/ruff/pull/6851](https://github.com/astral-sh/ruff/pull/6851) - fix is_raw_string for multiple prefixes by [@​davidszotten](https://github.com/davidszotten) in [https://github.com/astral-sh/ruff/pull/6865](https://github.com/astral-sh/ruff/pull/6865) - Add jupyter notebook cell ids in 4.5+ if missing by [@​konstin](https://github.com/konstin) in [https://github.com/astral-sh/ruff/pull/6853](https://github.com/astral-sh/ruff/pull/6853) **Full Changelog**: astral-sh/ruff@v0.0.285...v0.0.286 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/allenporter/flux-local). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzYuNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
referenced
this pull request
in allenporter/pyrainbird
Aug 27, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://beta.ruff.rs/docs) ([source](https://github.com/astral-sh/ruff), [changelog](https://github.com/astral-sh/ruff/releases)) | `==0.0.285` -> `==0.0.286` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>astral-sh/ruff (ruff)</summary> ### [`v0.0.286`](https://github.com/astral-sh/ruff/releases/tag/v0.0.286) [Compare Source](https://github.com/astral-sh/ruff/compare/v0.0.285...v0.0.286) <!-- Release notes generated using configuration in .github/release.yml at v0.0.286 --> #### What's Changed ##### New Rules - \[`flake8-bugbear`] Update `function-call-in-argument-default` (`B008`) to ignore arguments with immutable annotations by [@​zanieb](https://github.com/zanieb) in [https://github.com/astral-sh/ruff/pull/6784](https://github.com/astral-sh/ruff/pull/6784) - \[`flake8-bugbear`] Update `mutable-argument-default` (`B006`) to use `extend-immutable-calls` when determining if annotations are immutable by [@​zanieb](https://github.com/zanieb) in [https://github.com/astral-sh/ruff/pull/6781](https://github.com/astral-sh/ruff/pull/6781) - \[`flake8-pie`] Implement `unnecessary-range-start` (`PIE808`) by [@​harupy](https://github.com/harupy) in [https://github.com/astral-sh/ruff/pull/6690](https://github.com/astral-sh/ruff/pull/6690) - \[`flake8-pytest-style`] Add autofix for `PT014` by [@​harupy](https://github.com/harupy) in [https://github.com/astral-sh/ruff/pull/6698](https://github.com/astral-sh/ruff/pull/6698) - \[`pylint`] Implement `no-self-use` (`R6301`) by [@​LaBatata101](https://github.com/LaBatata101) in [https://github.com/astral-sh/ruff/pull/6574](https://github.com/astral-sh/ruff/pull/6574) - \[`pylint`] Extend `repeated-equality-comparison-target` to check for mixed orderings and Yoda conditions. by [@​tjkuson](https://github.com/tjkuson) in [https://github.com/astral-sh/ruff/pull/6691](https://github.com/astral-sh/ruff/pull/6691) ##### Settings - Make isort's `detect-same-package` behavior configurable by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6833](https://github.com/astral-sh/ruff/pull/6833) ##### Bug Fixes - Apply RUF017 when start is passed via position by [@​hauntsaninja](https://github.com/hauntsaninja) in [https://github.com/astral-sh/ruff/pull/6664](https://github.com/astral-sh/ruff/pull/6664) - Use `typing_extensions.TypeAlias` for PYI026 fixes on pre-3.10 by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6696](https://github.com/astral-sh/ruff/pull/6696) - Ignore multi-comparisons in `repeated-equality-comparison-target` by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6705](https://github.com/astral-sh/ruff/pull/6705) - Accept empty inner calls in C414 by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6725](https://github.com/astral-sh/ruff/pull/6725) - Allow next in FBT exclusions by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6729](https://github.com/astral-sh/ruff/pull/6729) - Allow `ctypes.WinError()` in flake8-raise by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6731](https://github.com/astral-sh/ruff/pull/6731) - Ignore star imports when importing symbols in fixes by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6743](https://github.com/astral-sh/ruff/pull/6743) - Support C419 autofixes for set comprehensions by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6744](https://github.com/astral-sh/ruff/pull/6744) - Avoid attempting to fix unconventional submodule imports by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6745](https://github.com/astral-sh/ruff/pull/6745) - Don't trigger `eq-without-hash` when `__hash__` is explicitly set to `None` by [@​LaBatata101](https://github.com/LaBatata101) in [https://github.com/astral-sh/ruff/pull/6739](https://github.com/astral-sh/ruff/pull/6739) - Avoid E231 if comma is at end-of-line by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6747](https://github.com/astral-sh/ruff/pull/6747) - Truncate some messages in diagnostics by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6748](https://github.com/astral-sh/ruff/pull/6748) - Fix isolation groups for unused imports by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6774](https://github.com/astral-sh/ruff/pull/6774) - Avoid fixing D200 for docstrings that end in escapes by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6779](https://github.com/astral-sh/ruff/pull/6779) - Parenthesize expressions prior to LibCST parsing by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6742](https://github.com/astral-sh/ruff/pull/6742) - Fallback to end-of-file if ends in trailing continuation by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6789](https://github.com/astral-sh/ruff/pull/6789) - Confine repeated-equality-comparison-target to names and attributes by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6802](https://github.com/astral-sh/ruff/pull/6802) - Fix `native-literals` handling of int literal with attribute access by [@​zanieb](https://github.com/zanieb) in [https://github.com/astral-sh/ruff/pull/6792](https://github.com/astral-sh/ruff/pull/6792) - Fix `uncessary-coding-comment` fix when there's leading content by [@​zanieb](https://github.com/zanieb) in [https://github.com/astral-sh/ruff/pull/6775](https://github.com/astral-sh/ruff/pull/6775) - Avoid attempting to fix PT018 in multi-statement lines by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6829](https://github.com/astral-sh/ruff/pull/6829) - Update ERA100 to apply to commented dictionary items with trailing comments by [@​zanieb](https://github.com/zanieb) in [https://github.com/astral-sh/ruff/pull/6822](https://github.com/astral-sh/ruff/pull/6822) - Avoid parsing other parts of a format specification if replacements are present by [@​zanieb](https://github.com/zanieb) in [https://github.com/astral-sh/ruff/pull/6858](https://github.com/astral-sh/ruff/pull/6858) - Avoid panic in unused arguments rule for parameter-free lambda by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/astral-sh/ruff/pull/6679](https://github.com/astral-sh/ruff/pull/6679) - Avoid `C417` for `lambda` with default and variadic parameters by [@​dhruvmanila](https://github.com/dhruvmanila) in [https://github.com/astral-sh/ruff/pull/6752](https://github.com/astral-sh/ruff/pull/6752) - Add `networkx` to conventional aliases by [@​zanieb](https://github.com/zanieb) in [https://github.com/astral-sh/ruff/pull/6778](https://github.com/astral-sh/ruff/pull/6778) - Skip serializing cell ID if it's None by [@​harupy](https://github.com/harupy) in [https://github.com/astral-sh/ruff/pull/6851](https://github.com/astral-sh/ruff/pull/6851) - fix is_raw_string for multiple prefixes by [@​davidszotten](https://github.com/davidszotten) in [https://github.com/astral-sh/ruff/pull/6865](https://github.com/astral-sh/ruff/pull/6865) - Add jupyter notebook cell ids in 4.5+ if missing by [@​konstin](https://github.com/konstin) in [https://github.com/astral-sh/ruff/pull/6853](https://github.com/astral-sh/ruff/pull/6853) **Full Changelog**: astral-sh/ruff@v0.0.285...v0.0.286 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/allenporter/pyrainbird). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzYuNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a utility for transforming expressions via LibCST that automatically wraps the expression in parentheses, applies a user-provided transformation, then strips the parentheses from the generated code. LibCST can't parse arbitrary expression ranges, since some expressions may require parenthesization in order to be parsed properly. For example:
In this case, the expression range is:
Which isn't valid on its own. So, instead, we add "fake" parentheses around the expression.
We were already doing this in a few places, so this is mostly formalizing and DRYing up that pattern.
Closes #6720.