Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various panicks when linting black/src #13033

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Fix various panicks when linting black/src #13033

merged 1 commit into from
Aug 21, 2024

Conversation

MichaReiser
Copy link
Member

Summary

Fixes various panics when checking black/src due to TODO comments/not visited expressions

Test Plan

I ran red knot over black/src

@MichaReiser MichaReiser added the red-knot Multi-file analysis & type inference label Aug 21, 2024
@MichaReiser MichaReiser enabled auto-merge (squash) August 21, 2024 12:31
@MichaReiser MichaReiser merged commit a35cdbb into main Aug 21, 2024
16 checks passed
@MichaReiser MichaReiser deleted the fix-panics-when-checking-black branch August 21, 2024 12:35
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 21, 2024

CodSpeed Performance Report

Merging #13033 will improve performances by 7.97%

Comparing fix-panics-when-checking-black (ec58096) with main (0c98b59)

Summary

⚡ 1 improvements
✅ 31 untouched benchmarks

Benchmarks breakdown

Benchmark main fix-panics-when-checking-black Change
⚡ linter/default-rules[numpy/globals.py] 184.1 µs 170.5 µs +7.97%

@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@carljm carljm Awaiting requested review from carljm carljm is a code owner

Assignees
No one assigned
Labels
red-knot Multi-file analysis & type inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaReiser @AlexWaygood