Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename too-many-positional(-arguments) #12905

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Rename too-many-positional(-arguments) #12905

merged 1 commit into from
Aug 15, 2024

Conversation

JonathanPlasse
Copy link
Contributor

Summary

Test Plan

  • Run cargo nextest run

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 15, 2024

CodSpeed Performance Report

Merging #12905 will improve performances by 10.7%

Comparing JonathanPlasse:rename-too-many-positiona/-arguments (fbb2fe3) with main (b9da316)

Summary

⚡ 1 improvements
✅ 31 untouched benchmarks

Benchmarks breakdown

Benchmark main JonathanPlasse:rename-too-many-positiona/-arguments Change
⚡ linter/all-with-preview-rules[numpy/globals.py] 911.3 µs 823.2 µs +10.7%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 15, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@MichaReiser MichaReiser modified the milestone: v0.7 Aug 15, 2024
MichaReiser
MichaReiser approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@MichaReiser MichaReiser added the rule Implementing or modifying a lint rule label Aug 15, 2024
@MichaReiser MichaReiser merged commit 52d27be into astral-sh:main Aug 15, 2024
20 checks passed
@JonathanPlasse JonathanPlasse deleted the rename-too-many-positiona/-arguments branch August 15, 2024 16:23
@BrewTestBot BrewTestBot mentioned this pull request Aug 16, 2024
Merged
@Pierre-Sassoulas Pierre-Sassoulas mentioned this pull request Aug 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

Assignees
No one assigned
Labels
rule Implementing or modifying a lint rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename too-many-positional{→-arguments}
2 participants
@JonathanPlasse @MichaReiser