Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ruff] Implement
incorrectly-parenthesized-tuple-in-subscript
(RUF031
) #12480[ruff] Implement
incorrectly-parenthesized-tuple-in-subscript
(RUF031
) #12480Changes from 31 commits
8acd409
e9aa21c
d59408f
7882fcd
be86fe9
55c334a
ec086e8
284a194
9513c9c
5b0a92a
61106a6
f3db34e
3f5d5bb
a0e7b04
0c339ab
c2e350b
5e1e0a4
a696961
209add0
bf5947d
2a895b6
dedda82
d8ea3a2
f7ff6a3
dd3d881
cec2241
96fcb28
bbe1801
5a83811
4cc9eb5
767ae99
b95f068
84afc6e
ccf47a7
4ba055d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to use an
if...else
over a match instead of suppressing the clippy warning.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. Sometimes in this kind of situation it can be more readable to introduce a custom enum and match on that instead, e.g.
but here I'm not sure I really see the need; I think I'd just stick with
bool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this has been marked as resolved, but the comment hasn't been addressed