Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid recommending context manager in __enter__ implementations #11575

Merged
merged 1 commit into from
May 28, 2024
Merged

Avoid recommending context manager in __enter__ implementations #11575

merged 1 commit into from
May 28, 2024

Conversation

charliermarsh
Copy link
Member

Summary

Closes #11567.

@charliermarsh charliermarsh added the bug Something isn't working label May 28, 2024
@charliermarsh charliermarsh enabled auto-merge (squash) May 28, 2024 01:42
@charliermarsh charliermarsh merged commit a38c05b into main May 28, 2024
17 checks passed
@charliermarsh charliermarsh deleted the charlie/sim branch May 28, 2024 01:44
@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SIM115 false positive when using open() inside of a custom context manager __enter__
1 participant
@charliermarsh