Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint.exclude and format.exclude don't respect --force-exclude #8391

Closed
charliermarsh opened this issue Oct 31, 2023 · 0 comments · Fixed by #8393
Closed

lint.exclude and format.exclude don't respect --force-exclude #8391

charliermarsh opened this issue Oct 31, 2023 · 0 comments · Fixed by #8393
Assignees
@charliermarsh
Labels
bug Something isn't working cli Related to the command-line interface

Comments

@charliermarsh
Copy link
Member

No description provided.

@charliermarsh charliermarsh added bug Something isn't working cli Related to the command-line interface labels Oct 31, 2023
@charliermarsh charliermarsh self-assigned this Oct 31, 2023
@charliermarsh charliermarsh mentioned this issue Oct 31, 2023
Merged
charliermarsh added a commit that referenced this issue Oct 31, 2023
@charliermarsh
Respect --force-exclude for lint.exclude and format.exclude (#8393)
1642f4d 
## Summary

We typically avoid enforcing exclusions if a file was passed to Ruff
directly on the CLI. However, we also allow `--force-exclude`, which
ignores excluded files _even_ if they're passed to Ruff directly. This
is really important for pre-commit, which always passes changed files --
we need to exclude files passed by pre-commit if they're in the
`exclude` lists.

Turns out the new `lint.exclude` and `format.exclude` settings weren't
respecting `--force-exclude`.

Closes #8391.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliermarsh charliermarsh

Labels
bug Something isn't working cli Related to the command-line interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Respect --force-exclude for lint.exclude and format.exclude astral-sh/ruff
1 participant
@charliermarsh