Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICN does not detect networkx as nx #6763

Closed
AbdealiLoKo opened this issue Aug 22, 2023 · 2 comments · Fixed by #6778
Closed

ICN does not detect networkx as nx #6763

AbdealiLoKo opened this issue Aug 22, 2023 · 2 comments · Fixed by #6778
Labels
accepted Ready for implementation configuration Related to settings and configuration

Comments

@AbdealiLoKo
Copy link

I was using the flake8-import-conventions's ICN rules in my project.
I notice that the networkx as nx is not implemented in ruff's settings

The original library has support for networkx in ICN004 - https://github.com/joaopalmeiro/flake8-import-conventions#flake8-codes

TO reproduce:

$ cat /tmp/try.py
import networkx

$ ruff /tmp/try.py --isolated --select ICN
$ echo $?
0

$ ruff --version
ruff 0.0.285
@charliermarsh
Copy link
Member

This may've just been an oversight. PR welcome if you'd like :)

@charliermarsh charliermarsh added configuration Related to settings and configuration accepted Ready for implementation labels Aug 22, 2023
@charliermarsh
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation configuration Related to settings and configuration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants