Fix PLE251 rules with f-string escaping

**Summary** The `value` of the `FStringMiddle` for `f"""}}a�b"""` is `}a�b`, i.e. the curly brace escaping is decoded. If we iterate over string this gives us false indices causing exploding fixes for PLE251 rules (PLE2510, PLE2512, PLE2513, PLE2514, PLE2515). Instead, we now use the source range. Handles #7455 (comment) Handles #7455 (comment) **Test Plan** Minimized fuzzing cases as fixtures.
astral-sh · Oct 1, 2023 · 539e337 · 539e337
1 parent 2838f7a
commit 539e337
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/crates/ruff_linter/resources/test/fixtures/pylint/invalid_characters.py b/crates/ruff_linter/resources/test/fixtures/pylint/invalid_characters.py
diff --git a/crates/ruff_linter/src/rules/pylint/rules/invalid_string_characters.rs b/crates/ruff_linter/src/rules/pylint/rules/invalid_string_characters.rs
@@ -180,7 +180,9 @@ pub(crate) fn invalid_string_characters(
 ) {
     let text = match tok {
         Tok::String { .. } => locator.slice(range),
-        Tok::FStringMiddle { value, .. } => value.as_str(),
+        // The string value has already decoded escaped curly braces, which would gives us wrong
+        // column information
+        Tok::FStringMiddle { .. } => &locator.contents()[range],
         _ => return,
     };