This repository has been archived by the owner on Dec 18, 2017. It is now read-only.
Normalize path to output dir before "kpm pack" #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Verify that all paths are normalized |
|
Verified. Project dir path and output dir path are normalized. The values of |
ChengTian
force-pushed
the
normalize-output-path-before-kpm-pack
branch
from
419d58e
to
b32a301
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parent #646
@lodejard , thank you for your help. I reproduced the bug with KExpense project. The root cause is that value of
--outisartifacts\\_PublishedWebsites\KExpense, which is not well-formatted because it contains\\. I fixed this bug by normalizing the output path before any further processing.