Skip to content
This repository has been archived by the owner on Dec 18, 2017. It is now read-only.

Retry creating file stream in LockFileFormat #2103

Merged
merged 1 commit into from
Jun 19, 2015
Merged

Retry creating file stream in LockFileFormat #2103

merged 1 commit into from
Jun 19, 2015

Conversation

troydai
Copy link
Contributor

@troydai troydai commented Jun 19, 2015

@troydai
Copy link
Contributor Author

troydai commented Jun 19, 2015

@ChengTian

ChengTian
ChengTian reviewed Jun 19, 2015
View reviewed changes
src/Microsoft.Framework.PackageManager/Restore/LockFileFormat.cs
{
return new FileStream(filePath, FileMode.Open, FileAccess.Read, FileShare.Read);
}
catch (Exception ex)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to resolve the lockfile read/write conflicts in this PR. However, this will retry even when some other kinds of exceptions are thrown. Is it possible that we narrow down to a more specific exception?

@ChengTian
Copy link
Contributor

:shipit:

@troydai troydai force-pushed the trdai/release.retry.filestream branch from 117e75d to 1a15af7 Compare June 19, 2015 23:14
@troydai troydai merged commit 1a15af7 into release Jun 19, 2015
@troydai troydai deleted the trdai/release.retry.filestream branch June 19, 2015 23:23
@Eilon
Copy link
Member

Eilon commented Jun 23, 2015

Fixes #2097

@Eilon Eilon mentioned this pull request Jun 23, 2015
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-already-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@troydai @ChengTian @Eilon @dnfclas