Skip to content
This repository has been archived by the owner on Dec 18, 2017. It is now read-only.

Always show full name and version when running a valid dnu subcommand #1932

Merged
merged 1 commit into from
May 22, 2015
Merged

Always show full name and version when running a valid dnu subcommand #1932

merged 1 commit into from
May 22, 2015

Conversation

ChengTian
Copy link
Contributor

@ChengTian
Copy link
Contributor Author

Sample output:
showfulltitle

@ChengTian
Copy link
Contributor Author

Show the header info only when a subcommand is actually running. If you provide an invalid subcommand/argument/option, we don't show the header:

showfulltitle_error

ChengTian
ChengTian reviewed May 22, 2015
View reviewed changes
src/Microsoft.Framework.CommandLineUtils.Sources/CommandLine/CommandLineApplication.cs
@@ -432,6 +428,23 @@ public void ShowVersion()
Console.WriteLine(VersionGetter());
}

public string GetFullNameAndVersion()
{
return VersionGetter == null ? FullName : string.Format("{0} v{1}", FullName, VersionGetter());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file will be compiled by Mono msc compiler, which doesn't support string interpolation. So using string.Format() here

@BrennanConroy
Copy link
Member

:shipit:

@ChengTian ChengTian force-pushed the wei/always-show-dnu-header-info branch from ba529cb to d71ad51 Compare May 22, 2015 17:38
@ChengTian ChengTian merged commit d71ad51 into dev May 22, 2015
@ChengTian ChengTian deleted the wei/always-show-dnu-header-info branch May 22, 2015 17:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-already-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChengTian @BrennanConroy @dnfclas