This repository has been archived by the owner on Dec 18, 2017. It is now read-only.
Initial plumbing for version ranges #1057
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfowl
force-pushed
the
version-specs
branch
3 times, most recently
from
6240ebd
to
bf16be2
Compare
- Added RequestedVersion to Library as IVersionSpec - Removed Snapshots from SemanticVersion and added them to VersionSpec instead. - When searching through versions, PreferredRequestedVersion should be used. - Clean up restore from global.json
- Added LibraryRange and SemanticVersionRange
- Changed IsSnapshot to SemanticVersionFloatBehavior to allow floating parts
of the version generically. This allows for node like syntax like ^{version} and
~{version}.
- Changed places that had Library to LibraryRange
-
- Added default LibraryDependency.Type - Fixed null check in BuildContext
davidfowl
force-pushed
the
version-specs
branch
from
fd7d19f
to
84ad74f
Compare
- If a version is specified without floating behavior then only match if it's an exact version. The trick is to change the UnresolvedDependencyProvider to return a library with Resolved = false. This allows the unresolved dependency to be used in the cousin resolution, but if the unresolved dependency is chosen, it still won't work.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VersionSpec instead.
Things left to implement:
Support version ranges in project.json #442
/cc @lodejard @loudej