This repository has been archived by the owner on Dec 18, 2017. It is now read-only.
Rename kpm commands #1037
Closed
Rename kpm commands #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename related classes - Rename related functional tests
|
Just a note : https://github.com/aspnet/MusicStore/blob/dev/test/E2ETests/Common/DeploymentUtility.cs#L313 needs to change as well with this change. |
| { | ||
| c.Description = "Build NuGet packages for the project in given directory"; | ||
| c.Description = "Pack NuGet packages for the project in given directory"; |
There was a problem hiding this comment.
Build is still a better verb to use.
|
Changed script names in the latest commit: We also have |
| @@ -142,7 +142,7 @@ public int Main(string[] args) | |||
| }); | |||
| }); | |||
|
|
|||
| app.Command("build", c => | |||
| app.Command("pack", c => | |||
| { | |||
| c.Description = "Build NuGet packages for the project in given directory"; | |||
|
will this lead to additional changes in the tooling schema? other (new) downstream changes? |
from my perspective but I did not check thoroughly enough to be the primary reviewer.
|
Need a rebase after #1117 is checked in. |
|
We will do this in release branch. Please check the new PR: #1124 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parent #967
Follow-up reaction: #1035
Impacted units: Tooling, test scripts, build scripts, wiki pages