This repository has been archived by the owner on Dec 18, 2017. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 224
Rationalize type and function usage in native parts of DNX #1603
Comments
👍 👍 👍 |
Biggest concern with STL is if we are concerned about speed. Otherwise I'm all for it |
@moozzyk is this still relevant with all of your refactorings? |
@davidfowl - yes. Most of the occurrences are being fixed in #2263 which has not been merged yet. I will need to do a final sweep after #2263 is merged since fixing this was not the main goal there. |
moozzyk
pushed a commit
that referenced
this issue
Sep 28, 2015
moozzyk
pushed a commit
that referenced
this issue
Sep 29, 2015
moozzyk
pushed a commit
that referenced
this issue
Sep 29, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Currently we mix different aliases of types across the code e.g.
WCHAR*
,LPWSTR
,LPTSTR
are used all over the place (e.g. bool GetTrustedPlatformAssembliesList(WCHAR* szDirectory, bool bNative, LPWSTR pszTrustedPlatformAssemblies, size_t cchTrustedPlatformAssemblies))even though they are basically the same type.
Similarly we mix usage of
_T
andL
macros and also mix string functions like_tcs*
andwcs*
and_tprintf_s
vs.wprintf_s
We should just use one alias or ideally - switch to STL and not use them at all.
We could consider creating our own alias for
std::string
andstd::wstring
(like dnx::string_t) type that would be used across the codebase regardless of what platform we are using.The text was updated successfully, but these errors were encountered: