-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 'tag' parsing #19
Conversation
Given that we're planning to allow wildcard patterns in the tag validator, is a link appropriate here? Or would we link only if there's no asterisk character in the tag value? |
The glob asterisk sure breaks the link here so imo it seems reasonable to remove it in this case. |
I have removed the link in case |
Okay, thanks! Sorry for the delay, I need to either locate someone with the expertise to review this or learn something about the package myself. I'll bring it up at our morning meeting. |
No hurry. I wasn't sure how much development is going on with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good. At some point we'll want to use the asdf library to resolve these but that can wait for now. I'll add an issue so we remember to do that at some point.
After using
tag
in place of$ref
more often (see asdf#814) I started to miss seeing the reference (+hyperlink) in thesphinx-asdf
output that gets generated from$ref
Without going into details of the
sphinx-asdf
code I implemented a few snippets that (hopefully) parse thetag
keywords similar to$ref
. Some small examples I ran looked the way I expected.Something like this:
Could this be added to
sphinx-asdf
?