-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary dependency #1576
Conversation
as user API is not changed, and users will not need to update their environments, is a change log entry necessary? I guess it doesn't hurt to still have one |
Its useful to have in the changelog simply because the dropping of the dependency does change the Conda configuration slightly. (That is we will need to drop the dependency from the conda forge configuration) |
I'm all for cleaning up this if indeed the splitting up of the standard has been abandoned. However until @perrygreenfield @nden @eslavich and other stake holders can weight in I don't think we should undo the work that has been done. |
Looking at my notes for ASDF 3.0, the question of keeping/removing this dependency is moot. It is my understanding that as part of ASDF 3.0 (which is the main development path for ASDF now), we would stop packaging schemas which are no longer part of the ASDF-standard. Originally, the The original proposal for breaking ASDF-standard apart into more sub-packages, including I have not included the removal of |
By this I mean that ASDF-standard has made significant changes to its schemas which have not being properly propagated into the packages it was intended to be split into. As such, the work initially carried out to facilitate this, including asdf-format/asdf-standard#342, needs to almost entirely be re-done in order to ensure that no loss of changes will occur and that the git history can be properly followed, if the ASDF developers wish to continue with the proposed "split". |
asdf-unit-schemas
was never necessary forasdf
, it only existed so that asdf-format/asdf-standard#342 could be merged without issue.Since that entire line of support has been abandoned at this point, this dependency should be dropped.