test for valid fileno before creating RealFile #1557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Python 3.8 devdeps failures are addressed in: #1556 |
braingram
force-pushed
the
fsspec_fileno
branch
2 times, most recently
from
e614ad5
to
6811d27
Compare
WilliamJamieson
approved these changes
Jul 3, 2023
fileno is needed for memory mapping and numpy.frombuffer. Test that fileno does not result in an ``io.UnsupportedOperation`` before creating a ``generic_io.RealFile`` and if the error occurs, create a ``generic_io.RandomAccessFile`` instead. fixes issue asdf-format#1552
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fileno is needed for memory mapping and numpy.frombuffer. Test that fileno does not result in an
io.UnsupportedOperationbefore creating ageneric_io.RealFileand if the error occurs, create ageneric_io.RandomAccessFileinstead.fixes issue #1552