drop depending on astropy.io.misc.asdf for test #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing and opening to retrigger docs build. |
braingram
force-pushed
the
astropy_asdf_drop
branch
from
86dee01
to
5b8e01b
Compare
braingram
force-pushed
the
astropy_asdf_drop
branch
from
5b8e01b
to
3e1127e
Compare
braingram
force-pushed
the
astropy_asdf_drop
branch
from
3e1127e
to
152af9d
Compare
nden
approved these changes
May 3, 2023
|
Thanks @nden for the review! |
braingram
added a commit
to braingram/asdf
that referenced
this pull request
Aug 1, 2023
drop depending on astropy.io.misc.asdf for test (cherry picked from commit 0e3b3e4)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Astropy removed astropy.io.misc.asdf in their development version.
astropy/astropy#14668
ASDF has one test that silently depended on the astropy.io.misc.asdf submodule to provide an equality function for an AffineTransform.
The PR removing the public API for the legacy extension already deals with this issue but is unlikely to be quickly merged: #1464
This PR includes the updated test from #1464 to not depend on the types provided by the now non-existent astropy.io.misc.asdf which is causing devdeps jobs to fail (as seen in CI runs for this PR #1531).