add upper pin to jsonschema

[braingram]

jsonschema 4.18 will introduce changes that are incompatible with asdf. More details can be found in:
#1485

this commit adds an upper pin to jsoncschema and removes it from the devdeps testing

As described in the issue, adding a warning filter was insufficient to allow the devdeps jobs to pass.

An issue was created to track removing the pin: #1486

[WilliamJamieson]

I am normally against commenting things out instead of removing them.

In this case, I want it clearly documented why we have stopped the testing against jsonschema dev and why we have introduced an upper pin within the code itself. Otherwise, it becomes unclear when examining the code at first glance why these changes have been made and the intent for them to be temporary changes.

[WilliamJamieson]

As described in the issue, adding a warning filter was insufficient to allow the devdeps jobs to pass.

Should an issue with jsonschema be opened about this? That clearly indicates the changes are not backwards compatible.

[braingram]

Should an issue with jsonschema be opened about this? That clearly indicates the changes are not backwards compatible.

I am suspicious that something is up with the reference resolution in meta schemas but so far I've been unable to come up with a non-asdf minimal case that fails. Given the extensive use of non-public portions of jsonschema within asdf it's possible the changes did not introduce any public backwards incompatibility and the issues we're encountering are our own fault. I'd rather wait to open an issue until we can determine that jsonschema is at fault.

[WilliamJamieson]

Hopefully these changes will be temporary

[pllim]

I vaguely remember a maxversion pin of jsonschema in the past, and eventually that gave astropy problems when something else required a new jsonschema that asdf cannot use. So hopefully this won't stay forever. 🤞

[WilliamJamieson]

@meeseeksdev backport to 2.14.x

[lumberbot-app]

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

git checkout 2.14.x
git pull

2. Cherry pick the first parent branch of the this PR on top of the older branch:

git cherry-pick -x -m1 b8e1759aa9f013283942140c94732a170eb9a703

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

git commit -am 'Backport PR #1487: add upper pin to jsonschema'

4. Push to a named branch:

git push YOURFORK 2.14.x:auto-backport-of-pr-1487-on-2.14.x

5. Create a PR against branch 2.14.x, I would have named this PR:

"Backport PR #1487 on branch 2.14.x (add upper pin to jsonschema)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.