remove astropy and specutils from downstream #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braingram
added
no-changelog-entry-needed
Downstream CI
development
braingram
force-pushed
the
ci/remove_astropy_and_specutils
branch
from
e4a45ad
to
6df6434
Compare
WilliamJamieson
force-pushed
the
ci/remove_astropy_and_specutils
branch
from
6df6434
to
7b2f368
Compare
WilliamJamieson
suggested changes
Mar 10, 2023
braingram
force-pushed
the
ci/remove_astropy_and_specutils
branch
from
7b2f368
to
58069f3
Compare
WilliamJamieson
approved these changes
Mar 10, 2023
| @@ -143,8 +127,7 @@ commands_pre = | |||
| pip install -r {env_tmp_dir}/requirements.txt | |||
| pip freeze | |||
| commands = | |||
| pytest asdf-astropy \ | |||
| -W "ignore::asdf.exceptions.AsdfDeprecationWarning:asdf.tests.helpers" | |||
There was a problem hiding this comment.
Note, this change should be "backported" to 2.15.x.
braingram
pushed a commit
to braingram/asdf
that referenced
this pull request
Aug 1, 2023
…and_specutils (cherry picked from commit a612e90)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
astropy was included here because of astropy.io.misc.asdf which is deprecated and uses the legacy extension api (which will be removed during this development cycle). The remaining usage of asdf in astropy is through asdf-astropy.
specutils includes a legacy extension that may be moved to asdf-astropy. Per advice from WilliamJamieson specutils is being removed from downstream testing.