Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update schemas for ASDF standard 1.6.0 #110

Merged
merged 6 commits into from
Mar 7, 2024

Conversation

braingram
Copy link
Contributor

No description provided.

@braingram braingram changed the title TEST: update for 1.6.0 standard Update schemas for ASDF standard 1.6.0 Feb 20, 2024
@braingram braingram marked this pull request as ready for review February 20, 2024 14:27
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure why there's one failure with remap-axes-1.4.0.
LGTM

@braingram
Copy link
Contributor Author

Thanks for reviewing this PR.

The failure of the CI/Run schemas and dev extensions job is due to asdf-astropy being installed from main (instead of the branch specified in the pyproject.toml test section in this PR). The main version isn't aware of the new manifest added in this PR (so it's not aware of remap_axis-1.4.0). It stems from the "chicken egg" that is this package and asdf-astropy (where a change here is required before asdf-astropy yet that same change "breaks" asdf-astropy as seen here).

@braingram braingram force-pushed the standard_1p6p0 branch 2 times, most recently from 49af497 to 00d79f6 Compare March 6, 2024 19:15
@braingram
Copy link
Contributor Author

As this PR no longer adds asdf-astropy-dev as a dependency in pyproject.toml the failures mentioned above for Run schemas and dev extensions now appear in other CI runs (like CI / Python 3.11 Schema validation tests). Once this PR is merged and this package released asdf-astropy can be updated to fix the CI.

@braingram braingram merged commit b329bc8 into asdf-format:main Mar 7, 2024
4 of 11 checks passed
@braingram braingram deleted the standard_1p6p0 branch March 7, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants