Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(builder): add Builder.io #13

Merged
merged 10 commits into from
Feb 24, 2023
Merged

feat(builder): add Builder.io #13

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a04a2aa
Add Builder.io
steve8708 Feb 22, 2023
1a5de01
Fix accidentally checked in file
steve8708 Feb 22, 2023
70a6f1d
Update src/transformers/builder.ts
steve8708 Feb 23, 2023
7d6e3f9
PR feedback and aim to get tests to pass
steve8708 Feb 23, 2023
582017f
Small tweaks
steve8708 Feb 23, 2023
5a7ff5c
Minor fix
steve8708 Feb 23, 2023
4a07941
Fix test
steve8708 Feb 23, 2023
e037dd9
Tests passing
steve8708 Feb 23, 2023
a5197ff
Fixes
steve8708 Feb 23, 2023
c498e51
Minor CSS suggestion
steve8708 Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion demo/src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,14 @@ summary {


.imagePanel {

display: grid;
place-items: center;
}

.imagePanel img {
object-fit: cover;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ascorbic I added this so that the img behavior matches the CDN ones

previously if you typed in a new value for width/height (esp one that the CDN needs to now generate) it would show a distorted image (stretch the image, which I think there is pretty much no case where people would want to do this in production - aka the default object-fit) and then it snaps into place when the CDN is updated

since all CDNs by default use cover, I changed the img behavior accordingly so when you change width/height it won't look distorted while the new one loads. in most cases you just see it be pixelated for a sec, and then it snaps to being nice and clear

felt more right/intuitive, but happy to remove if intentionally undesired

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to change that myself, so thanks!

}

.code {
overflow: auto;
}
Expand Down