Skip to content

Commit

Permalink
Make percy a development dependency
Browse files Browse the repository at this point in the history
- Install percy as a development dependency instead of installing it
  as a separate build step.
- [Replace deprecated `waitFor` with `waitForTimeout`][1].
- Explicitly add `--theme .` argument to the `npx resume` command.

[1]: puppeteer/puppeteer#6214
  • Loading branch information
asbjornu committed May 7, 2023
1 parent 61cc4f1 commit 48b20fc
Show file tree
Hide file tree
Showing 4 changed files with 10,304 additions and 4,243 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ jobs:
node-version: 10.x
cache: npm
- run: npm ci
- run: npm install --no-save @percy/script
- run: npm run build:styles
- run: npx resume serve --resume=example-resume.json --port 5001 --silent &
- run: npx resume serve --resume=example-resume.json --theme . --port 5001 --silent &
- run: sleep 2s
- run: npx percy exec -- node tests/percy.js
Loading

0 comments on commit 48b20fc

Please sign in to comment.