This repository has been archived by the owner on Mar 12, 2020. It is now read-only.
[Relay] Uses latest version and our patches #982
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| { | ||
| "plugins": [["relay", { "artifactDirectory": "./src/__generated__" }]], | ||
| "presets": ["react-native"] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| CHANGELOG.md merge=union | ||
| src/__generated__/*.graphql.ts linguist-generated | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,6 @@ | |
| ## Build generated | ||
| build/ | ||
| DerivedData | ||
| dist | ||
|
|
||
| ## Various settings | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| src/__generated__/*.ts | ||
| node_modules | ||
|
There was a problem hiding this comment. Turns out that the graphql-js patch wasn’t applying because the whole file had changed due to prettier on save :) |
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| patch-package | ||
| --- a/node_modules/graphql/utilities/assertValidName.js | ||
| +++ b/node_modules/graphql/utilities/assertValidName.js | ||
| @@ -41,13 +41,13 @@ function assertValidName(name) { | ||
| */ | ||
| function isValidNameError(name, node) { | ||
| !(typeof name === 'string') ? (0, _invariant2.default)(0, 'Expected string') : void 0; | ||
| - if (name.length > 1 && name[0] === '_' && name[1] === '_' && | ||
| - // Note: this special case is not part of the spec and exists only to | ||
| - // support legacy server configurations. Do not rely on this special case | ||
| - // as it may be removed at any time. | ||
| - name !== '__configs__') { | ||
| - return new _GraphQLError.GraphQLError('Name "' + name + '" must not begin with "__", which is reserved by ' + 'GraphQL introspection.', node); | ||
| - } | ||
| + // if (name.length > 1 && name[0] === '_' && name[1] === '_' && | ||
| + // // Note: this special case is not part of the spec and exists only to | ||
| + // // support legacy server configurations. Do not rely on this special case | ||
| + // // as it may be removed at any time. | ||
| + // name !== '__configs__') { | ||
| + // return new _GraphQLError.GraphQLError('Name "' + name + '" must not begin with "__", which is reserved by ' + 'GraphQL introspection.', node); | ||
| + // } | ||
| if (!NAME_RX.test(name)) { | ||
| return new _GraphQLError.GraphQLError('Names must match /^[_a-zA-Z][_a-zA-Z0-9]*$/ but "' + name + '" does not.', node); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff, thanks @pchaigno 🥇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orta - can you explain whats going on here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can - here's the historical context: https://twitter.com/pchaigno/status/961134607113637889
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tyty, makes sense 👍