-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Badges using npm-badger #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this. Looks good.
I left few minor comments, can you get those fixed. We can merge once this is done.
README.md
Outdated
@@ -1,5 +1,13 @@ | |||
# search-a-tags | |||
|
|||
[![NPM Version](https://img.shields.io/npm/v/search-a-tags-hacktoberfest.svg)](https://www.npmjs.com/package/search-a-tags-hacktoberfest) | |||
[![NPM Downloads](https://img.shields.io/npm/dt/search-a-tags-hacktoberfest.svg)](https://www.npmjs.com/package/search-a-tags-hacktoberfest) | |||
[![Github Repo Size](https://img.shields.io/github/repo-size/AryanAg08/search-a-tags-hacktoberfest.svg)](https://github.com/AryanAg08/search-a-tags-hacktoberfest) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[![Github Repo Size](https://img.shields.io/github/repo-size/AryanAg08/search-a-tags-hacktoberfest.svg)](https://github.com/AryanAg08/search-a-tags-hacktoberfest) | |
[![Github Repo Size](https://img.shields.io/github/repo-size/arshadkazmi42/search-a-tags-hacktoberfest.svg)](https://github.com/arshadkazmi42/search-a-tags-hacktoberfest) |
README.md
Outdated
[![NPM Version](https://img.shields.io/npm/v/search-a-tags-hacktoberfest.svg)](https://www.npmjs.com/package/search-a-tags-hacktoberfest) | ||
[![NPM Downloads](https://img.shields.io/npm/dt/search-a-tags-hacktoberfest.svg)](https://www.npmjs.com/package/search-a-tags-hacktoberfest) | ||
[![Github Repo Size](https://img.shields.io/github/repo-size/AryanAg08/search-a-tags-hacktoberfest.svg)](https://github.com/AryanAg08/search-a-tags-hacktoberfest) | ||
[![LICENSE](https://img.shields.io/npm/l/search-a-tags-hacktoberfest.svg)](https://github.com/AryanAg08/search-a-tags-hacktoberfest/blob/master/LICENSE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[![LICENSE](https://img.shields.io/npm/l/search-a-tags-hacktoberfest.svg)](https://github.com/AryanAg08/search-a-tags-hacktoberfest/blob/master/LICENSE) | |
[![LICENSE](https://img.shields.io/npm/l/search-a-tags-hacktoberfest.svg)](https://github.com/arshadkazmi42/search-a-tags-hacktoberfest/blob/master/LICENSE) |
README.md
Outdated
@@ -1,5 +1,13 @@ | |||
# search-a-tags | |||
|
|||
[![NPM Version](https://img.shields.io/npm/v/search-a-tags-hacktoberfest.svg)](https://www.npmjs.com/package/search-a-tags-hacktoberfest) | |||
[![NPM Downloads](https://img.shields.io/npm/dt/search-a-tags-hacktoberfest.svg)](https://www.npmjs.com/package/search-a-tags-hacktoberfest) | |||
[![Github Repo Size](https://img.shields.io/github/repo-size/AryanAg08/search-a-tags-hacktoberfest.svg)](https://github.com/AryanAg08/search-a-tags-hacktoberfest) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change all occurrences of AryanAg08
to arshadkazmi42
otherwise it will point to your forked repository. You can do a find and replace
README.md
Outdated
[![Contributors](https://img.shields.io/github/contributors/AryanAg08/search-a-tags-hacktoberfest.svg)](https://github.com/AryanAg08/search-a-tags-hacktoberfest/graphs/contributors) | ||
[![Commit](https://img.shields.io/github/last-commit/AryanAg08/search-a-tags-hacktoberfest.svg)](https://github.com/AryanAg08/search-a-tags-hacktoberfest/commits/master) | ||
|
||
|
||
[![Build](https://github.com/arshadkazmi42/search-a-tags/actions/workflows/nodejs.yml/badge.svg)](https://github.com/arshadkazmi42/search-a-tags/actions/workflows/nodejs.yml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move this to line 3, we want build badge to be the first badge in the list
okk! thanks for reviewing my pr!! Changes have been made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks
No description provided.