feat(argo-workflows): Define supported Kubernetes version #2169
Conversation
Signed-off-by: yu-croco <yu.croco@gmail.com>
Signed-off-by: yu-croco <yu.croco@gmail.com>
| @@ -6,6 +6,12 @@ If you want your deployment of this helm chart to most closely match the [argo C | |||
|
|
|||
| ## Pre-Requisites | |||
|
|
|||
| ### Supported Versions | |||
| - Kubernetes: `>=1.23.0-0` | |||
| - We align with [Amazon EKS calendar][EKS EoL] because there are many AWS users and it's a conservative approach. | |||
There was a problem hiding this comment.
charts/argo-workflows/Chart.yaml
Outdated
| version: 0.31.0 | ||
| version: 0.32.0 |
There was a problem hiding this comment.
This PR may give users an impact, so I wonder this is the time to bump major version ...? 🤔
There was a problem hiding this comment.
I recently bumped the supported version on the Workflows end: https://github.com/argoproj/argo-workflows/pull/11267/files
So I guess the right time is to do this when this gets released. I have no idea if it'll go into the next patch or not. The release process is... unclear.
There was a problem hiding this comment.
Thank you for the info. :)
That's a good idea to wait. I turn this PR into draft until then.
There was a problem hiding this comment.
Actually - because my change was just CI and docs, it's already released, there's nothing to cherry pick into the next patch.
Any new PRs will be run against k8s 1.27 already. So I've stll managed to avoid your question, but made the potential answer even more complicated.
There was a problem hiding this comment.
Oh I see.
Any new PRs will be run against k8s 1.27 already
Well, then it seems that we can move on this PR...? 👀
There was a problem hiding this comment.
Tricky one because the docs (that admittedly I was the last one to update) are unclear.
They both support k8s 1.21-1.27 AND only support 1.25-1.27. So that's nice and clear then :) However, if it was fully my choice, I'd make your change now. Any company using an EOL k8s version for production things a) probably isn't keeping on top of helm chart updates anyway and b) kinda deserves what they get :)
yu-croco
added
the
awaiting-upstream
yu-croco
force-pushed
the
add-support-k8s-version-to-argowf
branch
from
4f5338b
to
0372742
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
same as #2141 and #2087 .
This PR has an impact to users who use old K8s cluster, so please feel free to tell me your opinions. 🙏
Checklist: