chore(argo-cd): Add app.kubernetes.io/version label

[yu-croco]

resolves #2118 🙋

Checklist:

• I have bumped the chart version according to versioning
• I have updated the documentation according to documentation
• I have updated the chart changelog with all the changes that come with this pull request according to changelog.
• Any new values are backwards compatible and/or have sensible default.
• I have signed off all my commits as required by DCO.
• My build is green (troubleshooting builds).

[yu-croco]

https://helm.sh/docs/chart_best_practices/labels/#standard-labels

"argo-cd.labels" is used to all of resources, so I think it's ok to add this label here. 🙋

[sathieu]

This fails when the tag includes the digest :

metadata.labels: Invalid value: "v2.7.6@sha256:7daba5f38b23f4f091951b727db6f87dc04ad396fd21044401502438d633836e": must be no more than 63 characters, metadata.labels: Invalid value: "v2.7.6@sha256:7daba5f38b23f4f091951b727db6f87dc04ad396fd21044401502438d633836e": a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue', or 'my_value', or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?')

I'll propose a PR to fix this.

[sathieu]

Actually, this was already discussed #1427 (comment).

And the conclusion was to drop the label. What should I do now?

[sathieu]

Here is my proposed solution: #2148