Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(github): Introduce chart signing #2040

Merged
merged 1 commit into from
May 10, 2023
Merged

feat(github): Introduce chart signing #2040

merged 1 commit into from
May 10, 2023

Conversation

mkilchhofer
Copy link
Member

@mkilchhofer mkilchhofer commented May 10, 2023 •
edited
Loading

Resolves #2024

Testing is done in my own fork:

The newly required secrets are already in place:
repository secrets

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@mkilchhofer
feat(github): Introduce chart signing
5924f10 
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
yu-croco
yu-croco approved these changes May 10, 2023
View reviewed changes
Copy link
Collaborator

@yu-croco yu-croco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mkilchhofer mkilchhofer mentioned this pull request May 10, 2023
Merged
6 tasks
@mkilchhofer mkilchhofer merged commit 07aa087 into main May 10, 2023
@mkilchhofer mkilchhofer deleted the feature/signed_chart_releases branch May 10, 2023 13:06
@mkilchhofer mkilchhofer mentioned this pull request Mar 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmeridth jmeridth jmeridth approved these changes

@yu-croco yu-croco yu-croco approved these changes

@mbevc1 mbevc1 Awaiting requested review from mbevc1

@pdrastil pdrastil Awaiting requested review from pdrastil

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Signed chart releases
3 participants
@mkilchhofer @jmeridth @yu-croco