-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add Mono Repo Usage #9556
docs: Add Mono Repo Usage #9556
Conversation
3714c67
to
1e061ee
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #9556 +/- ##
=======================================
Coverage 49.01% 49.01%
=======================================
Files 247 247
Lines 42685 42685
=======================================
Hits 20924 20924
Misses 19645 19645
Partials 2116 2116 see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Just requesting a tweak.
Can I get a second review from someone more familiar w/ notifications?
Signed-off-by: Murat Akdeniz <makdeniz@msn.com>
Signed-off-by: Murat Akdeniz <makdeniz@msn.com>
036e253
to
7f475b9
Compare
This fixed the issue we were having with multiple applications in the same manifest repo. When application A had changes, notifications were triggered for application B. Changing the |
@@ -66,6 +65,10 @@ data: | |||
send: [app-sync-succeeded] | |||
``` | |||
|
|||
**Mono Repo Usage** | |||
|
|||
When one repo is used to sync multiple applications, the `oncePer: app.status.sync.revision` field will trigger a notification for each commit. For mono repos, the better approach will be using `oncePer: app.status.operationState.syncResult.revision` statement. This way a notification will be sent only for a particular Application's revision. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this save my life
This is helpful with applicationset-based repos where you attach annotations dynamically on every application and only the changed app should send the notification |
Hi @crenshaw-dev, |
I'm not a notifications expert, but makes sense to me. Thanks @makdeniz! |
* doc:notifications triggers Signed-off-by: Murat Akdeniz <makdeniz@msn.com> * a small tweak Signed-off-by: Murat Akdeniz <makdeniz@msn.com> --------- Signed-off-by: Murat Akdeniz <makdeniz@msn.com>
* doc:notifications triggers Signed-off-by: Murat Akdeniz <makdeniz@msn.com> * a small tweak Signed-off-by: Murat Akdeniz <makdeniz@msn.com> --------- Signed-off-by: Murat Akdeniz <makdeniz@msn.com>
Signed-off-by: Murat Akdeniz makdeniz@msn.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: