Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Redis should reconnect on connectivity issue #7207

Merged
merged 3 commits into from
Sep 15, 2021
Merged

fix: Redis should reconnect on connectivity issue #7207

merged 3 commits into from
Sep 15, 2021

Conversation

pasha-codefresh
Copy link
Member

Closes #6336

Signed-off-by: pashavictorovich <pavel@codefresh.io>
@pasha-codefresh pasha-codefresh changed the title fix: redis should reconnect on connectivity issue fix: Redis should reconnect on connectivity issue Sep 13, 2021
@pasha-codefresh pasha-codefresh self-assigned this Sep 13, 2021
@pasha-codefresh pasha-codefresh added this to the v2.2 milestone Sep 13, 2021
Signed-off-by: pashavictorovich <pavel@codefresh.io>
@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #7207 (9b609d0) into master (49378a9) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7207      +/-   ##
==========================================
- Coverage   41.03%   41.02%   -0.02%     
==========================================
  Files         158      159       +1     
  Lines       21299    21319      +20     
==========================================
+ Hits         8741     8746       +5     
- Misses      11305    11320      +15     
  Partials     1253     1253              
Impacted Files Coverage Δ
util/cache/redis_hook.go 12.50% <12.50%> (ø)
util/cache/cache.go 53.93% <39.13%> (-3.03%) ⬇️
util/session/state.go 69.09% <50.00%> (-0.73%) ⬇️
util/settings/settings.go 47.15% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49378a9...9b609d0. Read the comment docs.

Signed-off-by: pashavictorovich <pavel@codefresh.io>
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit 6f794d0 into argoproj:master Sep 15, 2021
plakyda-codefresh pushed a commit to plakyda-codefresh/argo-cd that referenced this pull request Sep 21, 2021
fix: Redis should reconnect on connectivity issue (argoproj#7207)

Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: viktorplakida <plakyda1@gmail.com>
plakyda-codefresh pushed a commit to plakyda-codefresh/argo-cd that referenced this pull request Sep 28, 2021
fix: Redis should reconnect on connectivity issue (argoproj#7207)

Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: viktorplakida <plakyda1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

argocd-server does not try to reconnect to redis on DNS error
2 participants