Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update ARGOCD_REPO_SERVER_PLUGIN_USE_MANIFEST_GENERATE_PATHS env… #20131

Closed
wants to merge 3 commits into from

Conversation

kpanter
Copy link

@kpanter kpanter commented Sep 27, 2024

… for argocd-repo-server deployment

our validation workflow detected below error
❌ FAIL: stdin - Deployment argocd-repo-server is invalid: problem validating schema. Check JSON formatting: jsonschema: '/spec/template/spec/containers/0/env/21' does not validate with https://github.com/yannh/kubernetes-json-schema/master/master-standalone-strict/deployment-apps-v1.json#/properties/spec/properties/template/properties/spec/properties/containers/items/properties/env/items/additionalProperties: additionalProperties 'configMapKeyRef' not allowed

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

… for argocd-repo-server deployment

our validation workflow detected below error
  ❌ FAIL: stdin - Deployment argocd-repo-server is invalid: problem validating schema. Check JSON formatting: jsonschema: '/spec/template/spec/containers/0/env/21' does not validate with https://github.com/yannh/kubernetes-json-schema/master/master-standalone-strict/deployment-apps-v1.json#/properties/spec/properties/template/properties/spec/properties/containers/items/properties/env/items/additionalProperties: additionalProperties 'configMapKeyRef' not allowed



Signed-off-by: Krzysiek <krzysztof.panter@volue.com>
@kpanter kpanter requested a review from a team as a code owner September 27, 2024 07:09
Copy link

bunnyshell bot commented Sep 27, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

bunnyshell bot commented Sep 27, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.87%. Comparing base (ca91dd9) to head (8b5f373).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20131      +/-   ##
==========================================
+ Coverage   55.86%   55.87%   +0.01%     
==========================================
  Files         321      321              
  Lines       44492    44492              
==========================================
+ Hits        24854    24860       +6     
+ Misses      17072    17068       -4     
+ Partials     2566     2564       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev
Copy link
Member

@kpanter good catch. The install.yaml is rendered based on Kustomize manifests, so the primary problem is in a different file. Once you find that file, you can run make manifests-local to regenerate install.yaml.

@blakepettersson
Copy link
Member

This is a duplicate of #20139 right?

@kpanter
Copy link
Author

kpanter commented Sep 30, 2024

@kpanter good catch. The install.yaml is rendered based on Kustomize manifests, so the primary problem is in a different file. Once you find that file, you can run make manifests-local to regenerate install.yaml.

Updated argocd-repo-server-deployment.yaml under manifests/base/repo-server and executed make manifests-local

@kpanter
Copy link
Author

kpanter commented Sep 30, 2024

This is a duplicate of #20139 right?

yes, right

@kpanter
Copy link
Author

kpanter commented Sep 30, 2024

duplicate of #20139

@kpanter kpanter closed this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants