feat(cli): add support for multiple sources to sync command #18016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ishitasequeira <ishiseq29@gmail.com> use arrays instead of map to display ApplicationManifetQuery fields in swagger Signed-off-by: ishitasequeira <ishiseq29@gmail.com> rebase and update logic for sync command Signed-off-by: ishitasequeira <ishiseq29@gmail.com> update conditions Signed-off-by: ishitasequeira <ishiseq29@gmail.com> update displayRevisions on OperationState Signed-off-by: ishitasequeira <ishiseq29@gmail.com> remove rerunreport file Signed-off-by: ishitasequeira <ishiseq29@gmail.com> fix index 0 out of bounds error Signed-off-by: ishitasequeira <ishiseq29@gmail.com> Address comments Signed-off-by: ishitasequeira <ishiseq29@gmail.com> fix codegen Signed-off-by: ishitasequeira <ishiseq29@gmail.com> rename GetSourcePtrBySourceIndex to GetSourcePtrByIndex Signed-off-by: ishitasequeira <ishiseq29@gmail.com> rename GetSourcePtrBySourcePosition to GetSourcePtrByPosition Signed-off-by: ishitasequeira <ishiseq29@gmail.com> rebase with master and resolve conflicts Signed-off-by: ishitasequeira <ishiseq29@gmail.com> fix codegen Signed-off-by: ishitasequeira <ishiseq29@gmail.com> Address feedback and add tests Signed-off-by: ishitasequeira <ishiseq29@gmail.com> fix unit test Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
ishitasequeira
changed the title
todaywasawesome
approved these changes
Apr 29, 2024
| @@ -1849,6 +1851,9 @@ func NewApplicationSyncCommand(clientOpts *argocdclient.ClientOptions) *cobra.Co | |||
| argocd app sync -l '!app.kubernetes.io/instance' | |||
| argocd app sync -l 'app.kubernetes.io/instance notin (my-app,other-app)' | |||
|
|
|||
| # Sync a multi-source application for specific revision of specific sources | |||
| argocd app manifests my-app --revisions 0.0.1 --source-positions 1 --revisions 0.0.2 --source-positions 2 | |||
There was a problem hiding this comment.
Hmm, I wonder if we should have named sources too. Maybe a followup PR, not worth stalling this one.
There was a problem hiding this comment.
There is an open issue opened for the same as a future enhancement. #17731
| "type": "array", | ||
| "items": { | ||
| "type": "string", | ||
| "format": "int64" |
There was a problem hiding this comment.
We could probably use int8, I doubt we'll ever have more than 127 source positions to worry about.
There was a problem hiding this comment.
Unfortunately, the command flagset does not support int8. Kept it int64 to avoid unwanted typecasting between command and api server.
pasha-codefresh
approved these changes
Apr 29, 2024
pasha-codefresh
approved these changes
Apr 29, 2024
pasha-codefresh
merged commit f875931
into
argoproj:release-2.11
21 of 23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picking #17808
Checklist: