Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): oci certificates (#14877) (cherry-pick #16656) #17320

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

gcp-cherry-pick-bot[bot]
Copy link

Cherry-picked Corrected certificate managment for OCI helm charts (#16656)

Signed-off-by: Andrew Block andy.block@gmail.com
Co-authored-by: Soumya Ghosh Dastidar 44349253+gdsoumya@users.noreply.github.com

Signed-off-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Soumya Ghosh Dastidar <44349253+gdsoumya@users.noreply.github.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot requested a review from a team as a code owner February 27, 2024 03:30
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 49.69%. Comparing base (f5d6b29) to head (735f92b).

Files Patch % Lines
util/helm/cmd.go 0.00% 31 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-2.10   #17320      +/-   ##
================================================
- Coverage         49.73%   49.69%   -0.04%     
================================================
  Files               271      271              
  Lines             47948    47979      +31     
================================================
  Hits              23845    23845              
- Misses            21753    21784      +31     
  Partials           2350     2350              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ishitasequeira ishitasequeira enabled auto-merge (squash) February 27, 2024 21:37
@ishitasequeira ishitasequeira merged commit 28a9225 into release-2.10 Feb 27, 2024
18 of 23 checks passed
@ishitasequeira ishitasequeira deleted the cherry-pick-3fcd4d-release-2.10 branch February 27, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants