Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backporting kustomize build dir patch from 2.10 #17132

Conversation

prune998
Copy link
Contributor

@prune998 prune998 commented Feb 7, 2024

Make kustomize use the project root dir as a base path.

Backported from release 2.10

Fixes #15057

@prune998 prune998 requested a review from a team as a code owner February 7, 2024 19:33
@prune998 prune998 changed the title backporting kustomize build dir patch from 2.10 fix: backporting kustomize build dir patch from 2.10 Feb 7, 2024
Signed-off-by: Prune <prune@lecentre.net>
@prune998 prune998 force-pushed the prune/backport-kustomize-build-dir branch from f1fd141 to 2ec6f45 Compare February 7, 2024 19:52
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ba62a0a) 50.10% compared to head (2ec6f45) 50.10%.

Files Patch % Lines
cmd/argocd/commands/app.go 0.00% 1 Missing ⚠️
reposerver/repository/repository.go 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           release-2.9   #17132   +/-   ##
============================================
  Coverage        50.10%   50.10%           
============================================
  Files              267      267           
  Lines            46223    46226    +3     
============================================
+ Hits             23159    23161    +2     
- Misses           20795    20796    +1     
  Partials          2269     2269           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ishitasequeira ishitasequeira merged commit 7cac5a8 into argoproj:release-2.9 Feb 7, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants