fix(redis): go-redis v9 regression missing metrics and reconnect hook (#13415) (cherry-pick #15275) #17025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcp-cherry-pick-bot[bot]](https://avatars.githubusercontent.com/in/169664?s=60&v=4){kind=small}
…#13415) (#15275) * fix(redis): go-redis v9 regression missing metrics and reconnect hook Signed-off-by: phanama <yudiandreanp@gmail.com> * fix: golangci lint return values not checked in tests Signed-off-by: phanama <yudiandreanp@gmail.com> * chore: move dnsError var locally into func Signed-off-by: phanama <yudiandreanp@gmail.com> --------- Signed-off-by: phanama <yudiandreanp@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-2.10 #17025 +/- ##
================================================
+ Coverage 49.35% 49.40% +0.05%
================================================
Files 272 272
Lines 47890 47884 -6
================================================
+ Hits 23635 23658 +23
+ Misses 21920 21891 -29
Partials 2335 2335 ☔ View full report in Codecov by Sentry. |
crenshaw-dev
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked fix(redis): go-redis v9 regression missing metrics and reconnect hook (#13415) (#15275)
Signed-off-by: phanama yudiandreanp@gmail.com
Signed-off-by: phanama yudiandreanp@gmail.com
Signed-off-by: phanama yudiandreanp@gmail.com
Signed-off-by: phanama yudiandreanp@gmail.com