fix(appcontroller): Uptake fix in gitops engine which fixes application sync with auto create ns and server side apply (cherry-pick #16942) #16963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcp-cherry-pick-bot[bot]](https://avatars.githubusercontent.com/in/169664?s=60&v=4){kind=small}
…on sync with auto create ns and server side apply (#16942) * Uptake fix in gitops engine to fix auto create ns with server side apply Signed-off-by: anandf <anjoseph@redhat.com> * Moved the new e2e test to different location Signed-off-by: anandf <anjoseph@redhat.com> * Fix test name to be less than 63 char for creating ns Signed-off-by: anandf <anjoseph@redhat.com> * update gitops-engine with latest master Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> --------- Signed-off-by: anandf <anjoseph@redhat.com> Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
ishitasequeira
approved these changes
Jan 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-2.10 #16963 +/- ##
=============================================
Coverage 49.32% 49.32%
=============================================
Files 272 272
Lines 47888 47888
=============================================
Hits 23622 23622
Misses 21932 21932
Partials 2334 2334 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to address the following issues:
#16840
#16829
#13874
Cherry-picked fix(appcontroller): Uptake fix in gitops engine which fixes application sync with auto create ns and server side apply (#16942)
Signed-off-by: anandf anjoseph@redhat.com
Signed-off-by: anandf anjoseph@redhat.com
Signed-off-by: anandf anjoseph@redhat.com
Signed-off-by: Leonardo Luz Almeida leonardo_almeida@intuit.com
Signed-off-by: anandf anjoseph@redhat.com
Signed-off-by: Leonardo Luz Almeida leonardo_almeida@intuit.com
Co-authored-by: Leonardo Luz Almeida leonardo_almeida@intuit.com