Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add context to configmap example #16763

Merged
merged 1 commit into from
Jan 5, 2024
Merged

docs: add context to configmap example #16763

merged 1 commit into from
Jan 5, 2024

Conversation

crenshaw-dev
Copy link
Member

Make it a bit clearer what needs to be changed?

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev crenshaw-dev requested review from a team as code owners January 5, 2024 18:56
Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoluz leoluz enabled auto-merge (squash) January 5, 2024 18:59
@crenshaw-dev
Copy link
Member Author

/cherry-pick release-2.10

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4afddf7) 49.50% compared to head (2f2cc97) 49.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #16763   +/-   ##
=======================================
  Coverage   49.50%   49.50%           
=======================================
  Files         271      271           
  Lines       47793    47793           
=======================================
  Hits        23658    23658           
  Misses      21796    21796           
  Partials     2339     2339           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leoluz leoluz merged commit c4ac5aa into master Jan 5, 2024
27 of 28 checks passed
@leoluz leoluz deleted the crenshaw-dev-patch-1 branch January 5, 2024 20:13
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jan 5, 2024
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
jannfis pushed a commit that referenced this pull request Jan 6, 2024
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
ebuildy pushed a commit to ebuildy/argo-cd that referenced this pull request Jan 7, 2024
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: ebuildy <ebuildy@gmail.com>
JulienFuix pushed a commit to JulienFuix/argo-cd that referenced this pull request Feb 6, 2024
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
penglongli pushed a commit to penglongli/argo-cd that referenced this pull request Mar 6, 2024
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: penglongli <pelenli@tencent.com>
lyda pushed a commit to lyda/argo-cd that referenced this pull request Mar 28, 2024
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Kevin Lyda <kevin@lyda.ie>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants