feat: webhook should use 'rename' to copy app manifests of previous commit #16754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ommit Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #16754 +/- ##
==========================================
+ Coverage 49.48% 49.50% +0.01%
==========================================
Files 271 271
Lines 47728 47793 +65
==========================================
+ Hits 23620 23658 +38
- Misses 21773 21796 +23
- Partials 2335 2339 +4 ☔ View full report in Codecov by Sentry. |
wanghong230
approved these changes
Jan 4, 2024
ebuildy
pushed a commit
to ebuildy/argo-cd
that referenced
this pull request
Jan 7, 2024
…ommit (argoproj#16754) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: ebuildy <ebuildy@gmail.com>
alexmt
added a commit
to alexmt/argo-cd
that referenced
this pull request
Jan 19, 2024
…ommit (argoproj#16754) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
JulienFuix
pushed a commit
to JulienFuix/argo-cd
that referenced
this pull request
Feb 6, 2024
…ommit (argoproj#16754) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
clement-heetch
pushed a commit
to clement-heetch/argo-cd
that referenced
this pull request
Feb 12, 2024
…ommit (argoproj#16754) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
13 tasks
penglongli
pushed a commit
to penglongli/argo-cd
that referenced
this pull request
Mar 6, 2024
…ommit (argoproj#16754) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: penglongli <pelenli@tencent.com>
lyda
pushed a commit
to lyda/argo-cd
that referenced
this pull request
Mar 28, 2024
…ommit (argoproj#16754) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Kevin Lyda <kevin@lyda.ie>
aborilov
pushed a commit
to aborilov/argo-cd
that referenced
this pull request
Apr 29, 2024
…ommit (argoproj#16754) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
…ommit (argoproj#16754) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #14269
The manifests path annotation feature implementation causes Redis high memory usage. After the Git repository receives a new commit, the webhook handler copies the manifest of multiple applications using the
get&setRedis commands. As a result, it transfers a lot of data from and into Redis while leaving unnecessary copies of old manifests.The PR changes implementation to use
renamecommand. It significantly reduces Redis traffic, improves webhook performance, and eliminates memory spikes.