Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix broken link #16722

Merged
merged 1 commit into from
Dec 31, 2023
Merged

docs: fix broken link #16722

merged 1 commit into from
Dec 31, 2023

Conversation

noam-codefresh
Copy link
Contributor

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: Noam Gal <noam.gal@codefresh.io>
@noam-codefresh noam-codefresh requested review from a team as code owners December 31, 2023 14:18
@noam-codefresh noam-codefresh changed the title fix broken link docs: fix broken link Dec 31, 2023
Copy link

codecov bot commented Dec 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f0f4a4e) 49.49% compared to head (842468a) 49.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #16722      +/-   ##
==========================================
- Coverage   49.49%   49.48%   -0.01%     
==========================================
  Files         271      271              
  Lines       47728    47728              
==========================================
- Hits        23622    23620       -2     
- Misses      21772    21773       +1     
- Partials     2334     2335       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@PranitRout07 PranitRout07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In triggers.md file there is function.md file is imported . Can you include these changes also
Screenshot 2023-12-31 202303 .Here the underlined URLs need to be updated ,for e.g. https://golang.org/pkg/time/#Time should be updated to https://golang.org/pkg/time#Time (no slash after time) , https://golang.org/pkg/time/#Now should be updated to https://golang.org/pkg/time#Now (no slash after time) .

Copy link
Member

@gdsoumya gdsoumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blakepettersson
Copy link
Member

In triggers.md file there is function.md file is imported...

Those links redirect to the proper urls so is fine IMO. Perhaps for another PR?

@blakepettersson blakepettersson merged commit 80ca563 into argoproj:master Dec 31, 2023
25 of 26 checks passed
@noam-codefresh noam-codefresh deleted the patch-1 branch January 2, 2024 07:49
sonamkshenoy pushed a commit to sonamkshenoy/argo-cd that referenced this pull request Jan 3, 2024
Signed-off-by: Noam Gal <noam.gal@codefresh.io>
Signed-off-by: sshenoy6 <sonamkaup_shenoy@intuit.com>
bcho pushed a commit to bcho/argo-cd that referenced this pull request Jan 4, 2024
Signed-off-by: Noam Gal <noam.gal@codefresh.io>
Signed-off-by: hbc <bcxxxxxx@gmail.com>
ebuildy pushed a commit to ebuildy/argo-cd that referenced this pull request Jan 7, 2024
Signed-off-by: Noam Gal <noam.gal@codefresh.io>
Signed-off-by: ebuildy <ebuildy@gmail.com>
JulienFuix pushed a commit to JulienFuix/argo-cd that referenced this pull request Feb 6, 2024
Signed-off-by: Noam Gal <noam.gal@codefresh.io>
clement-heetch pushed a commit to clement-heetch/argo-cd that referenced this pull request Feb 12, 2024
Signed-off-by: Noam Gal <noam.gal@codefresh.io>
penglongli pushed a commit to penglongli/argo-cd that referenced this pull request Mar 6, 2024
Signed-off-by: Noam Gal <noam.gal@codefresh.io>
Signed-off-by: penglongli <pelenli@tencent.com>
lyda pushed a commit to lyda/argo-cd that referenced this pull request Mar 28, 2024
Signed-off-by: Noam Gal <noam.gal@codefresh.io>
Signed-off-by: Kevin Lyda <kevin@lyda.ie>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
Signed-off-by: Noam Gal <noam.gal@codefresh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants