Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update contributors-quickstart.md to include a link to Go's installation guide #16691

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

markestiller
Copy link
Contributor

Signed-off by: Mark Estiller markalestiller@gmail.com

This change adds a link to Go's official installation guide under the "Install Go" section to ensure that first-time contributors download a version of Go that is compatible.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

…ion guide

Signed-off-by: Mark Estiller <markalestiller@gmail.com>
@markestiller markestiller requested review from a team as code owners December 23, 2023 19:52
@markestiller markestiller changed the title Update contributors-quickstart.md to include a link to Go's installation guide docs: Update contributors-quickstart.md to include a link to Go's installation guide Dec 23, 2023
Copy link

codecov bot commented Dec 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cbe6e2b) 49.54% compared to head (cbd73bf) 49.48%.
Report is 53 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #16691      +/-   ##
==========================================
- Coverage   49.54%   49.48%   -0.06%     
==========================================
  Files         269      271       +2     
  Lines       47222    47728     +506     
==========================================
+ Hits        23395    23620     +225     
- Misses      21528    21773     +245     
- Partials     2299     2335      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@PranitRout07 PranitRout07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @markestiller i would suggest to put the go's installation link below the install description .

@blakepettersson blakepettersson merged commit 20f7182 into argoproj:master Dec 28, 2023
25 of 26 checks passed
sonamkshenoy pushed a commit to sonamkshenoy/argo-cd that referenced this pull request Jan 3, 2024
…ion guide (argoproj#16691)

Signed-off-by: Mark Estiller <markalestiller@gmail.com>
Signed-off-by: sshenoy6 <sonamkaup_shenoy@intuit.com>
bcho pushed a commit to bcho/argo-cd that referenced this pull request Jan 4, 2024
…ion guide (argoproj#16691)

Signed-off-by: Mark Estiller <markalestiller@gmail.com>
Signed-off-by: hbc <bcxxxxxx@gmail.com>
ebuildy pushed a commit to ebuildy/argo-cd that referenced this pull request Jan 7, 2024
…ion guide (argoproj#16691)

Signed-off-by: Mark Estiller <markalestiller@gmail.com>
Signed-off-by: ebuildy <ebuildy@gmail.com>
JulienFuix pushed a commit to JulienFuix/argo-cd that referenced this pull request Feb 6, 2024
…ion guide (argoproj#16691)

Signed-off-by: Mark Estiller <markalestiller@gmail.com>
clement-heetch pushed a commit to clement-heetch/argo-cd that referenced this pull request Feb 12, 2024
…ion guide (argoproj#16691)

Signed-off-by: Mark Estiller <markalestiller@gmail.com>
penglongli pushed a commit to penglongli/argo-cd that referenced this pull request Mar 6, 2024
…ion guide (argoproj#16691)

Signed-off-by: Mark Estiller <markalestiller@gmail.com>
Signed-off-by: penglongli <pelenli@tencent.com>
lyda pushed a commit to lyda/argo-cd that referenced this pull request Mar 28, 2024
…ion guide (argoproj#16691)

Signed-off-by: Mark Estiller <markalestiller@gmail.com>
Signed-off-by: Kevin Lyda <kevin@lyda.ie>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
…ion guide (argoproj#16691)

Signed-off-by: Mark Estiller <markalestiller@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants