Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add initiated by in history and rollback view #16654

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

robinlieb
Copy link
Member

Closes #16612

As mentioned in the issue this PR adds Initiated by in the history and rollback view.

argocd-16612

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@robinlieb robinlieb requested a review from a team as a code owner December 19, 2023 20:38
@robinlieb robinlieb force-pushed the feat/initiatedBy-in-history branch 2 times, most recently from 469afe1 to 72f15a1 Compare December 19, 2023 20:45
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3224102) 49.48% compared to head (d15baaa) 49.48%.
Report is 1 commits behind head on master.

Files Patch % Lines
controller/state.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #16654   +/-   ##
=======================================
  Coverage   49.48%   49.48%           
=======================================
  Files         271      271           
  Lines       47726    47728    +2     
=======================================
+ Hits        23619    23620    +1     
- Misses      21772    21773    +1     
  Partials     2335     2335           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @robinlieb for working on this!
Will wait for @keithchong to conclude the UI review before merging.

Copy link
Contributor

@keithchong keithchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leoluz , LGTM

Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robinlieb There is one last request in this PR. As you are changing the Application CRD, this needs to be stated in the "upgrading" doc.

As we just cut the 2.10 branch a few days ago, the file is not created yet. It needs to be created in:
/docs/operator-manual/upgrading/2.10-2.11.md and linked here:

- operator-manual/upgrading/2.9-2.10.md

See this doc as an example:
https://argo-cd.readthedocs.io/en/stable/operator-manual/upgrading/1.6-1.7/#appproject-tokens-moved-to-status-field

@robinlieb robinlieb requested a review from a team as a code owner December 22, 2023 15:56
Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com>
@robinlieb
Copy link
Member Author

@leoluz thanks for the hint! Added the respective upgrading doc and linked it in the mkdocs.yml

Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thank you!

@leoluz leoluz enabled auto-merge (squash) December 22, 2023 16:30
@leoluz leoluz merged commit 0e67ed8 into argoproj:master Dec 22, 2023
25 checks passed
ggkhrmv pushed a commit to ggkhrmv/argo-cd that referenced this pull request Dec 28, 2023
Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com>
bcho pushed a commit to bcho/argo-cd that referenced this pull request Jan 4, 2024
Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com>
Signed-off-by: hbc <bcxxxxxx@gmail.com>
ggkhrmv pushed a commit to ggkhrmv/argo-cd that referenced this pull request Jan 15, 2024
ggkhrmv added a commit to ggkhrmv/argo-cd that referenced this pull request Jan 15, 2024
…#16654)"

This reverts commit dfe4ca9

Signed-off-by: ggkhrmv <gg.khrmv@gmail.com>
parmou pushed a commit to parmou/argo-cd that referenced this pull request Jan 25, 2024
Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com>
JulienFuix pushed a commit to JulienFuix/argo-cd that referenced this pull request Feb 6, 2024
Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com>
clement-heetch pushed a commit to clement-heetch/argo-cd that referenced this pull request Feb 12, 2024
Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com>
penglongli pushed a commit to penglongli/argo-cd that referenced this pull request Mar 6, 2024
Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com>
Signed-off-by: penglongli <pelenli@tencent.com>
lyda pushed a commit to lyda/argo-cd that referenced this pull request Mar 28, 2024
Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com>
Signed-off-by: Kevin Lyda <kevin@lyda.ie>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com>
@ericblackburn
Copy link
Contributor

ericblackburn commented Aug 1, 2024

Edit: This is working for the Sync Status view, but always shows as Unknown on the History and Rollback view, even for the latest record.

v2.11.5+c4b283c

@eliya-gloat
Copy link

Same for me with release - v2.11.7+e4a0246 - All actions appears as user "unknown" for field "Initiated By"
v2.11.7+e4a0246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add user info in Argo CD history UI
5 participants