-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): Change group/grouped visualization argoproj#13565 #14904
fix(ui): Change group/grouped visualization argoproj#13565 #14904
Conversation
@vipinachar would you be able to add a screenshot of ui change? |
oh sorry, I had uploaded a video seems like there was some error. argo-cd-grouping.mp4 |
@ashutosh16 I have uploaded video of my changes |
Signed-off-by: Vipin M S <vipinachar2016@gmail.com>
c2314b4
to
dbd3ef9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14904 +/- ##
==========================================
+ Coverage 49.44% 49.90% +0.45%
==========================================
Files 273 262 -11
Lines 48662 44983 -3679
==========================================
- Hits 24063 22447 -1616
+ Misses 22237 20327 -1910
+ Partials 2362 2209 -153 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
Signed-off-by: Vipin M S <vipinachar2016@gmail.com> Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com> Signed-off-by: Kevin Lyda <kevin@lyda.ie>
Signed-off-by: Vipin M S <vipinachar2016@gmail.com> Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
Signed-off-by: Vipin M S <vipinachar2016@gmail.com> Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
Fixes: #13565
I have added the count of resources on resource tile. Please let me know if it needs ant changes
Demo:-
Uploading argo-cd-grouping.mp4…