Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: wrap ComparisonError messages (cherry-pick #14886) #14890

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

gcp-cherry-pick-bot[bot]
Copy link

Cherry-picked chore: wrap ComparisonError messages (#14886)

Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage: 16.47% and project coverage change: -0.03% ⚠️

Comparison is base (1ee5010) 49.92% compared to head (ed2ccf5) 49.90%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-2.8   #14890      +/-   ##
===============================================
- Coverage        49.92%   49.90%   -0.03%     
===============================================
  Files              262      262              
  Lines            44935    44963      +28     
===============================================
+ Hits             22435    22439       +4     
- Misses           20297    20317      +20     
- Partials          2203     2207       +4     
Files Changed Coverage Δ
controller/cache/cache.go 27.01% <0.00%> (ø)
controller/state.go 71.33% <0.00%> (-1.08%) ⬇️
util/db/helmrepository.go 0.00% <0.00%> (ø)
util/db/repository_legacy.go 46.77% <0.00%> (ø)
util/db/repository_secrets.go 68.35% <0.00%> (ø)
util/settings/settings.go 51.09% <16.66%> (ø)
util/argo/diff/diff.go 52.53% <18.18%> (-1.28%) ⬇️
util/db/repository.go 41.12% <37.93%> (-0.83%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev crenshaw-dev merged commit 3535ab9 into release-2.8 Aug 3, 2023
18 of 20 checks passed
@crenshaw-dev crenshaw-dev deleted the cherry-pick-ae401b-release-2.8 branch August 3, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant