fix: Correctly verify signatures when targetRevision is a branch name (cherry-pick #14214) #14235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcp-cherry-pick-bot[bot]](https://avatars.githubusercontent.com/in/169664?s=60&v=4){kind=small}
…#14214) * fix: Correctly verify signatures when targetRevision is a branch name Signed-off-by: jannfis <jann@mistrust.net> * Add more e2e tests Signed-off-by: jannfis <jann@mistrust.net> * Fix a bug and add unit test Signed-off-by: jannfis <jann@mistrust.net> --------- Signed-off-by: jannfis <jann@mistrust.net>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release-2.8 #14235 +/- ##
===============================================
+ Coverage 49.76% 49.78% +0.01%
===============================================
Files 261 261
Lines 44653 44672 +19
===============================================
+ Hits 22222 22238 +16
- Misses 20248 20249 +1
- Partials 2183 2185 +2
☔ View full report in Codecov by Sentry. |
crenshaw-dev
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked fix: Correctly verify signatures when targetRevision is a branch name (#14214)
Signed-off-by: jannfis jann@mistrust.net
Signed-off-by: jannfis jann@mistrust.net
Signed-off-by: jannfis jann@mistrust.net
Signed-off-by: jannfis jann@mistrust.net